This repository was archived by the owner on Oct 31, 2023. It is now read-only.
Don't append PackagePath if it's empty #112
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aslakhellesoy
force-pushed
the
dont-append-package-path-if-empty
branch
from
50a0ad0 to
4feb530
Compare
Author
|
Hi @mitchellh - any chance of getting this merged? Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Including the
PackagePathin the command when it's empty has strange side effects.In my case my
-ldflags "-X main.version=1.2.3"seemed to be ignored. (Theversionfield in mymaindid not get populated).This PR fixes the bug.