Skip to content

Fix adb execs for unix-like systems, use list-based adb args #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix adb execs for unix-like systems, use list-based adb args #52

wants to merge 2 commits into from

Conversation

@neneal
Copy link

@neneal neneal commented Oct 1, 2025 •
edited
Loading

  • Switched to list-based arguments instead of a string-based args to fix adb calls on Unix-like systems. Currently, they fail because they treat the string as a single command with no args. See here.
  • Improved the error message raised when start-app fails to find specified activities.

@neneal neneal force-pushed the main branch 4 times, most recently from d3c16d6 to 6e3f4d6 Compare October 1, 2025 23:19
@Davis-3450 Davis-3450 mentioned this pull request Oct 3, 2025
Merged
@Davis-3450
Copy link
Contributor

lgtm but it would be safer to merge the minimal fix first

@Davis-3450
Copy link
Contributor

try this: https://gist.github.com/Davis-3450/b2c8a6738ec716f29263850fc12ddad5 @neneal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@gcohen55 gcohen55 gcohen55 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@neneal @Davis-3450 @gcohen55