-
Notifications
You must be signed in to change notification settings - Fork 17
Security: Disable yarn postinstall scripts #5432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Security: Disable yarn postinstall scripts #5432
Conversation
Disable yarn's postinstall scripts to improve security by setting enableScripts: false in .yarnrc.yml
Summary of ChangesHello @ChristopherChudzicki, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the project's security posture by disabling Yarn's postinstall scripts. This change is a recommended security best practice, preventing the automatic execution of potentially malicious code during package installation and mitigating risks associated with supply chain attacks. While some packages might require manual script execution, the primary goal is to bolster security without impacting core application functionality. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request improves security by disabling yarn's postinstall scripts, which is a commendable security best practice. The change correctly implements this by adding enableScripts: false to .yarnrc.yml. My review highlights a resulting maintainability issue: the project's own postinstall script in package.json is now disabled but still present, which could cause confusion. I've recommended addressing this in a follow-up to improve project clarity.
| @@ -1,2 +1,3 @@ | |||
| yarnPath: .yarn/releases/yarn-3.1.1.cjs | |||
| nodeLinker: "node-modules" | |||
| enableScripts: false | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While this is a good security enhancement, it also disables the project's own postinstall script defined in package.json:
"postinstall": "./webpack_if_prod.sh"This script will no longer run automatically after yarn install, which can be confusing for developers who see the script in package.json and expect it to run.
To improve clarity and maintainability, I recommend removing the postinstall script from package.json in a follow-up PR. The build step (./webpack_if_prod.sh) should then be explicitly integrated into your CI/CD pipeline for production builds. This makes the build process more transparent and avoids reliance on postinstall hooks.
This PR was generated automatically via a script.
This PR disables yarn's postinstall scripts by setting
enableScripts: falsein.yarnrc.yml. It is part of:Why this change?
Disabling postinstall scripts improves security by:
What changed?
enableScripts: falseto.yarnrc.ymlImpact
This is a security best practice recommended for production applications to prevent potential malicious code execution during package installation.