Skip to content

add ability to specify strict mode using config #195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

add ability to specify strict mode using config #195

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
844a7f5
add ability to specify strict mode using config
jbwyme Mar 4, 2022
b61363b
update docs to use strict mode
jbwyme Mar 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion example.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ var Mixpanel = require('./lib/mixpanel-node');

// create an instance of the mixpanel client
var mixpanel = Mixpanel.init('962dbca1bbc54701d402c94d65b4a20e');
mixpanel.set_config({ debug: true });
mixpanel.set_config({ debug: true, strict: true });

// track an event with optional properties
mixpanel.track("my event", {
Expand Down
4 changes: 4 additions & 0 deletions lib/mixpanel-node.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,10 @@ var create_client = function(token, config) {
query_params.test = 1;
}

if (metrics.config.strict) {
query_params.strict = 1;
}

request_options.path = metrics.config.path + endpoint + "?" + querystring.stringify(query_params);

request = request_lib.request(request_options, function(res) {
Expand Down
5 changes: 3 additions & 2 deletions readme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,11 +18,12 @@ Quick Start
var Mixpanel = require('mixpanel');

// create an instance of the mixpanel client
var mixpanel = Mixpanel.init('<YOUR_TOKEN>');
var mixpanel = Mixpanel.init('<YOUR_TOKEN>', {strict: true});

// initialize mixpanel client configured to communicate over https
var mixpanel = Mixpanel.init('<YOUR_TOKEN>', {
protocol: 'https'
protocol: 'https',
strict: true,
});

// track an event with optional properties
Expand Down