Skip to content

Conversation

@ajsb85
Copy link

@ajsb85 ajsb85 commented Jul 26, 2019

Hi, @miyajan

I updated the repository using the new package for GitHub API REST.

Reference: #1

@miyajan
Copy link
Owner

miyajan commented Jul 28, 2019

Thank you for your pull request. But npm run build causes an error.

$ npm run build

> [email protected] build /Users/miyajan/project/node-github-release
> tsc

node_modules/@octokit/rest/index.d.ts:5:1 - error TS1084: Invalid 'reference' directive syntax.

5 /// <reference lib="esnext.asynciterable" />
  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~


npm ERR! code ELIFECYCLE
npm ERR! errno 2
npm ERR! [email protected] build: `tsc`
npm ERR! Exit status 2
npm ERR! 
npm ERR! Failed at the [email protected] build script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /Users/miyajan/.npm/_logs/2019-07-28T14_05_11_681Z-debug.log

It seems that the typescript's version is too older for the latest Octokit. Could you fix it? Or should I fix it?

@miyajan
Copy link
Owner

miyajan commented Jul 28, 2019

octokit/rest.js@1fff810
And some methods are renamed. They must be fixed.

@ajsb85
Copy link
Author

ajsb85 commented Aug 9, 2019

Hi, @miyajan
I will work on it very soon.
Thank you very much for the review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants