feat: move ORDER BY from BinaryQuery right side to SimpleQuery level #183
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clarifies UNION ORDER BY semantics by extracting ORDER BY clause from the rightmost query in binary operations and moving it to the outer SimpleSelectQuery level. This transforms ambiguous ORDER BY positioning into explicit subquery structure. Changes: - Add ORDER BY extraction logic to QueryBuilder.buildSimpleBinaryQuery() - Implement recursive ORDER BY detection in binary query trees - Move ORDER BY from individual subqueries to wrapper SimpleQuery - Add comprehensive tests for ORDER BY movement scenarios - Document SQL standard behavior for UNION ORDER BY clauses 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clarifies UNION ORDER BY semantics by extracting ORDER BY clause from
the rightmost query in binary operations and moving it to the outer
SimpleSelectQuery level. This transforms ambiguous ORDER BY positioning
into explicit subquery structure.
Changes:
🤖 Generated with Claude Code
Co-Authored-By: Claude [email protected]