just cpu things

[PhilipDeegan]

Summary by CodeRabbit

• New Features

  • Introduced utility methods for filling data containers with specified values.
  • Added a new configuration option to control the definition of the dim3 struct in CPU contexts.
  • Enhanced management of execution contexts with new support variables.

• Chores

  • Optimized internal function declarations for improved compilation performance.
  • Suppressed extraneous build notifications to streamline the build process.

[coderabbitai]

Walkthrough

This pull request updates several header files within the GPU module. The modifications in both gpu.hpp and gpu/cpu.hpp add the inline keyword to the declaration of the idx function. In addition, the CPU header now includes the <algorithm> header, new inline static variables, and two template functions to fill containers with a specified value. The preprocessor message in gpu/defines.hpp has also been commented out to prevent it from displaying during compilation. A new configuration option is added to the documentation regarding the definition of the dim3 struct.

Changes

File(s)	Change Summary
inc/mkn/gpu.hpp	Updated the idx function declaration in the mkn::gpu namespace to include the inline keyword.
inc/mkn/gpu/cpu.hpp	- Added <algorithm> header. - Introduced static inline variables threadIdx and blockIdx in dim3. - Added two template functions for filling containers. - Updated idx() with inline.
inc/mkn/gpu/defines.hpp	Commented out a preprocessor message directive to suppress compile-time messages regarding GPU accelerator detection.
README.noformat	Added a new configuration option MKN_CPU_DO_NOT_DEFINE_DIM3 (bool, default false) to skip defining the dim3 struct.

Sequence Diagram(s)

sequenceDiagram
    participant App as Application
    participant Fill as fill() Function
    participant Alg as std::fill

    App->>Fill: call fill(container, size, value)
    Fill->>Alg: invoke std::fill(begin, begin+size, value)
    Alg-->>Fill: container updated
    Fill-->>App: return updated container

Loading

Possibly related PRs

• inlined #26: The changes in the main PR are related to the addition of the inline keyword to the idx function, while the retrieved PR also modifies function declarations to include the inline keyword for print_gpu_mem_used, indicating a similar focus on inlining functions at the code level.

Poem

I'm a rabbit with a coding delight,
Hopping through headers, making things inline and light.
With fills like carrots neatly spread,
And warnings silenced from the compiler's head,
I nibble on changes, day and night.
🐰💻 Happy hops in every byte!

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c411c74 and a7ee032.

📒 Files selected for processing (4)

• README.noformat (1 hunks)
• inc/mkn/gpu.hpp (1 hunks)
• inc/mkn/gpu/cpu.hpp (4 hunks)
• inc/mkn/gpu/defines.hpp (0 hunks)

💤 Files with no reviewable changes (1)

• inc/mkn/gpu/defines.hpp

🚧 Files skipped from review as they are similar to previous changes (2)

• inc/mkn/gpu.hpp
• inc/mkn/gpu/cpu.hpp

🔇 Additional comments (1)

README.noformat (1)

45-48: Good addition of the configuration option.

The new configuration option is well-documented and follows the existing format pattern. This allows users to avoid duplicate definitions of the dim3 struct when they already have GPU headers included elsewhere in their project.

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai plan to trigger planning for file edits and PR creation.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.