yaml defaults

[PhilipDeegan]

Summary by CodeRabbit

• Chores
  • Updated CPU profile test configuration
  • Streamlined compiler settings for CUDA and HIP build configurations
  • Enabled active include paths in compiler configurations
  • Consolidated configuration structure with updated settings references

[coderabbitai]

Walkthrough

Three build configuration YAML files were updated: the CPU test profile disabled the GPU flag, while clang_cuda and hipcc configurations were refactored to introduce a new super: settings key and clean up repository configuration blocks.

Changes

Cohort / File(s)	Summary
Build Configuration Updates mkn.yaml, res/mkn/clang_cuda.yaml, res/mkn/hipcc.yaml	CPU profile: commented out -DMKN_GPU_CPU=1 flag to disable GPU support for CPU tests. Clang CUDA config: added super: settings key, re-enabled include path, removed commented repository blocks. HipCC config: added super: settings key, removed local block containing repo and mod-repo definitions.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

• Consider verifying:
  • Whether disabling the CPU GPU flag in the CPU test profile was intentional and doesn't affect expected test behavior
  • Whether the super: settings key replacement maintains the intended configuration hierarchy and inheritance chain
  • Whether removal of commented repository configuration blocks (especially in hipcc.yaml) won't impact build reproducibility or local/remote module resolution

Poem

🐰 Configuration files dance in the YAML light,
GPU flags fade to comment, CPU tests burn bright,
Super settings spring forth, old blocks take flight,
Include paths awakened, the build shines right! 🚀

Pre-merge checks and finishing touches

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Title check	❓ Inconclusive	The title 'yaml defaults' is vague and generic; it does not clearly convey what specific changes or improvements are being made to the YAML configuration files.	Use a more descriptive title that specifies the actual changes, such as 'Add super:settings configuration and enable include paths in YAML files' or 'Refactor YAML configuration structure for consistency'.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch next

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between fdc0308 and 76e9db0.

📒 Files selected for processing (3)

• mkn.yaml (1 hunks)
• res/mkn/clang_cuda.yaml (1 hunks)
• res/mkn/hipcc.yaml (1 hunks)

🧰 Additional context used

🧠 Learnings (1)

📓 Common learnings

Learnt from: PhilipDeegan
Repo: mkn/mkn.gpu PR: 19
File: test/any/async_streaming.cpp:2-6
Timestamp: 2024-06-10T19:38:12.663Z
Learning: PhilipDeegan, thank you for sharing your preferred style for organizing includes. I'll remember this for future reviews in your codebase.

<!--

PhilipDeegan prefers to sort `#include` statements by line length first, and alphabetically second.

🔇 Additional comments (4)

mkn.yaml (1)

23-28: Clarify the intent: CPU profile disables the GPU CPU flag despite comment suggesting it's for CPU-only testing.

The comment on line 23 states the cpu profile is for testing code without GPU hardware. However, the DMKN_GPU_CPU flag is now commented out (disabled). If this flag enables CPU-specific GPU code paths for testing, disabling it contradicts the stated purpose.

Verify: Should the flag remain active to allow proper CPU GPU code testing on systems without GPU hardware, or is disabling it the correct behavior for this profile?

res/mkn/hipcc.yaml (1)

1-3: Verify the super: settings key and its relationship to the removed repository configuration.

Line 3 introduces a new top-level key super: settings, which according to the summary replaces the removed local repository blocks. Without documentation of what this key does or how it migrates the removed configuration, it's unclear whether the change is complete and correct.

Request: Verify that super: settings is a valid mkn build system feature and confirm that the repository configuration has been properly migrated or is no longer needed.

res/mkn/clang_cuda.yaml (2)

14-15: Verify the super: settings key semantics (same concern as hipcc.yaml).

Line 14 introduces super: settings, which is also present in res/mkn/hipcc.yaml. Please confirm this is a valid mkn build system feature and document its purpose.

---

23-24: Hardcoded CUDA include/lib paths may break builds on systems with non-standard installations.

Lines 23-24 activate previously commented hardcoded paths:

• inc: /usr/local/cuda/targets/x86_64-linux/include
• path: /usr/local/cuda/targets/x86_64-linux/lib

These paths are system and architecture-specific (x86_64-linux). Uncommenting them unconditionally could break builds on:

• Systems with CUDA installed in non-standard locations
• Non-x86_64 architectures (ARM, etc.)

The env block assumes /usr/local/cuda/bin is in PATH, but the hardcoded include/lib paths suggest this assumption may not hold universally.

Verify: Should these paths be conditional, configurable, or derived from environment variables (e.g., ${CUDA_HOME}) rather than hardcoded?

Tip

📝 Customizable high-level summaries are now available!

You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.

• Provide custom instructions to shape the summary (bullet lists, tables, contributor stats, etc.).
• Use high_level_summary_in_walkthrough to move the summary from the description to the walkthrough section.

Example:

"Create a concise high-level summary as a bullet-point list. Then include a Markdown table showing lines added and removed by each contributing author."

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}