Using already existing nstack plist to obtain appid and apikey #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to hide away the keys and simplify the setup
|
The plist is used for fetching translations in the runscript, so why not use it for initialising NStack too? :) |
jakobmygind
suggested changes
Apr 25, 2022
jakobmygind
reviewed
Apr 28, 2022
Comment on lines
+45
to
+53
| var localizations: ObservableLocalizations = { | ||
| guard | ||
| let url = Bundle.main.url(forResource: "NStack", withExtension: "plist"), | ||
| let config = try? PropertyListDecoder().decode(NStackConfig.self, from: try Data(contentsOf: url)) | ||
| else { | ||
| fatalError("Failed to initialize NStack") | ||
| } | ||
| return startNStackSDK(appId: config.appId, restAPIKey: config.apiKey) | ||
| }() |
There was a problem hiding this comment.
Hmm, I think the callsite should be as it was where NStack is started just with the ids, but there could be a convenience function that would get the keys from the plist the lines before, I think this might be nice 😊 This seems a little more messy than is necessary in this particular location which we would like to be very clear, since it's the entrypoint for everything imo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to hide away the keys and simplify the setup