Skip to content

ci: check for public dependencies #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

mladedav
Copy link
Owner

@mladedav mladedav commented Jun 3, 2025

Motivation

We should not expose dependencies accidentally and we should have a check that lets us know that we need to do a breaking release when we update a public dependency.

Solution

Use the unstable cargo public dependencies.

@mladedav mladedav force-pushed the dm/public-dependencies branch from b3f40ef to 8db45b5 Compare June 3, 2025 10:14
@mladedav mladedav force-pushed the dm/public-dependencies branch from 8db45b5 to 4f02a34 Compare June 3, 2025 11:17
@mladedav mladedav marked this pull request as draft June 3, 2025 11:22
@mladedav
Copy link
Owner Author

mladedav commented Jun 3, 2025

This might have to wait for a bit since our current MSRV 1.75 rejects the Cargo.toml since it is not stable while newer (e.g. 1.83.0) cargo just prints warnings that we need to enable the unstable feature but otherwise just ignores the field.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant