feat: add popover introduction info for models #63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Neet-Nestor
requested changes
Sep 10, 2024
There was a problem hiding this comment.
Thanks for the contribution! It looks fine on my end, but for style consistency and package size we tend to not introduce additional packages, especially large ones like material UI unless absolute necessary.
For the popover you used, we have a native Popover implementation at ui-lib.js already. Could you try adopting it to see whether it is working? If so we can avoid introducing both emotion and material UI here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New feature: added a popover introduction for home screen's model selector, include info for each model's size, author, quantization, Vram required and more.
Desktop.2024.09.09.-.01.11.28.02.mp4