Skip to content

building 6.5.6 / 24.04 on my machine #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

li-nkSN
Copy link

@li-nkSN li-nkSN commented Jul 8, 2025

No description provided.

@li-nkSN li-nkSN marked this pull request as draft July 8, 2025 08:38
Copy link
Member

@ddennedy ddennedy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GitHub Actions will timeout when trying to build the qt image, and you need to build it locally and push it to DockerHub (your own account). Let me know when you have done that, and I will inspect it.

# Install Qt5 build dependencies - version specific
RUN if [ "${UBUNTU_VERSION}" = "24.04" ]; then \
# Ubuntu 24.04: qt5-default doesn't exist, use qtbase5-dev instead
apt-get -yqq install qtbase5-dev qtbase5-dev-tools || apt-get -yqq install \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not install qt5. build-dep is just a convenient way to get many dependencies since those are common between major versions. Maybe there is something like that better for qt6 on newer ubuntu.

Comment on lines -31 to +87
-D FEATURE_openssl_runtime=ON
-D FEATURE_openssl=ON
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why change this? I do not want to include OpenSSL and prefer to load it at runtime.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had open ssl errors otherwise

push: true
tags: mltframework/qt:6.4.3-ubuntu18.04
tags: mltframework/qt:6.5.6-ubuntu20.04
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you change this version? Did you build this and verify that builds using the version of g++ in Ubuntu 20.04. The reason this says ubuntu:18.04 is because GitHub Actions times out building this, and I need to build it locally and push the image. So, this workflow is not really used anymore.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. QT 6.4.3 is not available and breaks the build
  2. ubuntu 20.04 seemed to be the currently employed version for your other builds

Copy link
Member

@ddennedy ddennedy Jul 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mltframework/qt:6.4.3-ubuntu18.04 is not available, but mltframework/qt:6.4.3-ubuntu20.04 IS. The shotcut-build image for x86-64 MUST remain the way it is currently--on mltframework/qt:6.4.3-ubuntu20.04. Remove all changes to this file because it not used currently, and you must build the qt image yourself.

apt-get -yqq install clang-18 libclang-18-dev || apt-get -yqq install clang libclang-dev; \
else \
# Ubuntu 20.04/22.04: prefer clang-10
apt-get -yqq install clang-10 libclang-10-dev || apt-get -yqq install clang libclang-dev; \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using clang supports installing a newer version of C++ that is in newer Qt?

docker build --rm -t mltframework/qt:6.4.3-ubuntu20.04 docker/qt6-build
docker run -it --rm -v $PWD:/mnt mltframework/qt:6.4.3-ubuntu20.04
s3cmd --acl-public put qt-6.4.3-ubuntu20.04-x86_64.txz s3://misc.meltymedia/shotcut-build/
docker build --rm -t mltframework/qt:6.5.6-ubuntu20.04 docker/qt6-build
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This must remain mltframework/qt:6.4.3-ubuntu20.04


## Build Shotcut for Linux

docker build --rm -t mltframework/shotcut-build:qt6.4.3-ubuntu20.04 docker/shotcut-build
docker build --rm -t mltframework/shotcut-build:qt6.5.6-ubuntu20.04 docker/shotcut-build
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This must remain qt6.4.3-ubuntu20.04

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants