Skip to content

update golangci-lint to v2.1.6 #3202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 30 additions & 5 deletions .golangci.yml
Original file line number Diff line number Diff line change
@@ -1,15 +1,40 @@
version: "2"

run:
modules-download-mode: vendor
tests: false
timeout: 10m
linters:
disable-all: true

formatters:
enable:
- misspell
- gofmt
- goimports

linters:
default: none
enable:
- govet
- ineffassign
- misspell
- revive
- unconvert
- unused
- govet
exclusions:
presets:
- comments
- common-false-positives
- legacy
- std-error-handling
rules:
- linters:
- revive
text: "(unused-parameter|redefines-builtin-id):"
# Log a warning if an exclusion rule is unused.
# Default: false
warn-unused: true

issues:
# Maximum issues count per one linter. Set to 0 to disable. Default is 50.
max-issues-per-linter: 0

# Maximum count of issues with the same text. Set to 0 to disable. Default is 3.
max-same-issues: 0
2 changes: 1 addition & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

ARG GO_VERSION=1.18.9
ARG PROTOC_VERSION=3.11.4
ARG GOLANGCI_LINT_VERSION=v1.50.1
ARG GOLANGCI_LINT_VERSION=v2.1.6
ARG DEBIAN_FRONTEND=noninteractive

FROM --platform=$BUILDPLATFORM golang:${GO_VERSION}-bullseye AS gobase
Expand Down
4 changes: 2 additions & 2 deletions direct.mk
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,8 @@ version/version.go:
.PHONY: setup
setup: ## install dependencies
@echo "🐳 $@"
# install golangci-lint version v1.50.1 to ./bin/golangci-lint
@curl -fsSL https://raw.githubusercontent.com/golangci/golangci-lint/v1.50.1/install.sh | sh -s v1.50.1
# install golangci-lint version v2.1.6 to ./bin/golangci-lint
@curl -fsSL https://raw.githubusercontent.com/golangci/golangci-lint/HEAD/install.sh | sh -s v2.1.6
@(cd tools ; GO111MODULE=on go install github.com/containerd/protobuild)

.PHONY: generate
Expand Down