Introduce json schema generator customisation #139
Conversation
|
As described in the CONTRIBUTING doc, you should wait until we approve an issue before submitting code. |
| // It allows defining custom AdditionalProperties for a specific type. | ||
| // Also, SchemaRegistry can be used to provide pre-defined schemas for specific types (e.g., struct, interfaces) | ||
| type GeneratorOptions struct { | ||
| AdditionalProperties func(reflect.Type) *Schema // input is type name |
There was a problem hiding this comment.
#185 implements the schema registry. Can you explain why AdditionalProperties is necessary also? It seems like SchemaRegistry is all that's needed.
There was a problem hiding this comment.
Main issue was that interface field were not added to parent object. Because of this, MCP clients were reporting that structured response is not comply with schema. Registry should fix it.
BUT if there are another corner cases, additionalProperties should allow to resolve schema-related complains. At this point, I have implemented additionalProperties override after schema generation in our project
Introduce json schema generator customisation via GeneratorOptions
For #136