mcp: Add example of using Middleware for logging purposes #58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwjblue-glean
force-pushed
the
rwjblue/logging-middleware
branch
from
22d44b4 to
d87030f
Compare
rwjblue-glean
commented
Jun 26, 2025
jba
requested changes
Jun 27, 2025
There was a problem hiding this comment.
This should be a Go documentation example, not a separate program. See mcp/example_progress_test.go.
You won't need a lot of test infrastructure in that case. I would disable time output, and use the "// Output:" feature of examples for some very basic testing.
src/cmd/go/alldocs.go
If that doesn't work out for some reason, let me know and I'll reconsider.
|
Thank you @jba for taking a look! I will work on updating this evening. |
rwjblue-glean
force-pushed
the
rwjblue/logging-middleware
branch
from
d87030f to
accdc47
Compare
|
Sorry for the delay here @jba (I was out on vacation, and this slipped between the cracks); I've updated as you requested please take a look when you have time. |
jba
requested changes
Jul 17, 2025
|
Thank you for all of your help @jba! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
I needed to implement some logging for our experimental server that we are building out using the SDK, and figured I could propose an example that might make it easier for folks in the future.
For #33
How Has This Been Tested?
Implemented a small number of tests to ensure that the example continues to function over time.
Breaking Changes
N/A
Types of changes
Checklist
Additional context