feat: Adds optional _meta to request input forms. #514
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olaservo
requested changes
Jul 7, 2025
| @@ -108,6 +108,7 @@ export function useConnection({ | |||
| schema: T, | |||
| options?: RequestOptions & { suppressToast?: boolean }, | |||
| ): Promise<z.output<T>> => { | |||
| console.log("makeRequest:", request); | |||
There was a problem hiding this comment.
Could you remove this extra log?
Suggested change
| console.log("makeRequest:", request); |
| @@ -841,18 +890,19 @@ const App = () => { | |||
| tools={tools} | |||
| listTools={() => { | |||
| clearError("tools"); | |||
| listTools(); | |||
| listTools(); // TODO: Pass meta from ToolsTab if MetaEditor is added there | |||
olaservo
added
the
waiting on submitter
|
Hi @mbleigh curious if you are still planning to update this PR, or should I close it for now? |
|
OK sounds good @FelixBaum ! If you'd like to discuss details related to this implementation feel free to check out the Discord server mentioned in this post: https://blog.modelcontextprotocol.io/posts/2025-07-31-governance-for-mcp/ |
|
Sorry folks, I've been very busy lately and haven't had time to come back
to this. I can try to get back to it in the next few days.
…On Tue, Aug 5, 2025, 5:20 AM Ola Hungerford ***@***.***> wrote:
*olaservo* left a comment (modelcontextprotocol/inspector#514)
<#514 (comment)>
OK sounds good @FelixBaum <https://github.com/FelixBaum> ! If you'd like
to discuss details related to this implementation feel free to check out
the Discord server mentioned in this post:
https://blog.modelcontextprotocol.io/posts/2025-07-31-governance-for-mcp/
—
Reply to this email directly, view it on GitHub
<#514 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAAH7SEBXRMOIQP3LXWW2L3MCORRAVCNFSM6AAAAAB7N3XO3WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTCNJUHE4DQNJVG4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
The inspector currently has no mechanism of sending
_metainformation which means it can't be used to inspect/debug custom metadata uses.How Has This Been Tested?
I've tested this out with my custom MCP server that depends on certain
_metakeys and it seems to work well.Example screenshots:
Breaking Changes
No breaking changes.
Types of changes
Checklist
Additional context
modelcontextprotocol/modelcontextprotocol#710