-
Notifications
You must be signed in to change notification settings - Fork 769
initalize logging after connection #611
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
092246c
to
57b2976
Compare
57b2976
to
f4d9bf6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it makes sense to add the setLoggingLevel
to match the default selected level. I just had one comment. (And I think you have some linting errors that are failing the CI.)
Side note, I think the title of the issue you linked to this PR ("The MCP spec for logging requires a setLevel message before logs should be emitted ") doesn't seem accurate, since a server could still emit logs without this being set.
@olaservo I see you added the waiting for submitter tag - is there something else to do on my end? I thought I addressed your comment, lmk if there’s anything else you want from me :) |
Hi @antholeole , I'm good to merge this but for some reason some new formatting issues are showing up in the CI checks - could you resolve that? (If I make those changes it won't count my approval.) Thanks! |
Sgtm, will fix this tomorrow, thanks for taking another look. |
Head branch was pushed to by a user without write access
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Hello, This seem to lead to an issue discussed in #699, especially the code in useConnection Please check? |
after a connection is established, send a setLoggingLevel request
#610
Motivation and Context
How Has This Been Tested?
manually, but this is a very small change. i could write unit if required
Breaking Changes
None
Types of changes
Checklist