Skip to content

Add loading state and toast notifications to PingTab #671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

olishiz
Copy link

@olishiz olishiz commented Aug 1, 2025

  • Implement toast notifications for ping status (loading, success, error)
  • Add Bell icon to ping button for better UX

Motivation and Context

  • Better UI experience for the Ping toast message

How Has This Been Tested?

Production

Breaking Changes

No, only UI changes

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

Image as seen here:
image

- Implement toast notifications for ping status (loading, success, error)
- Add Bell icon to ping button for better UX
@olaservo
Copy link
Member

olaservo commented Aug 3, 2025

Hi @olishiz , thanks for the PR. Were you table to test this with a failed ping as well?

@olaservo olaservo added enhancement New feature request waiting on submitter Waiting for the submitter to provide more info labels Aug 3, 2025
@olishiz
Copy link
Author

olishiz commented Aug 4, 2025

Hi @olishiz , thanks for the PR. Were you table to test this with a failed ping as well?

Yes, I tested it locally as it seems when I shut down the server, it will show the error message.

Screenshot 2025-08-04 at 3 28 42 PM Screenshot 2025-08-04 at 4 05 13 PM

I believed the error will be handled properly and it will show on the toast message to the user

@olaservo olaservo removed the waiting on submitter Waiting for the submitter to provide more info label Aug 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants