feat: add error logging for onErrorResume #484
+290
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
##Summary
Added error logging to
onErrorResume
handlers in McpServerSession to capture full stack traces when request processing fails, addressing issue #249.Motivation and Context
Problem: The MCP server was silently swallowing exceptions in onErrorResume handlers, making debugging difficult.
Solution: Added comprehensive error logging that captures:
Before: Silent failures with no diagnostic information for
onErrorResume
After: Full error visibility while maintaining identical protocol behavior
How Has This Been Tested?
McpServerSessionRealErrorTest
with 4 comprehensive test scenariosBreaking Changes
None - This is a purely additive change:
Types of changes
Checklist
Additional context
TODO: Add structured error details to client responses while preserving security boundaries (The error message for the client side is currently null).