Skip to content

fix: Avoid NPE in McpClientSession #607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+9 −1
Open

fix: Avoid NPE in McpClientSession #607

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion mcp-core/src/main/java/io/modelcontextprotocol/spec/McpClientSession.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -277,7 +277,15 @@ public <T> Mono<T> sendRequest(String method, Object requestParams, TypeRef<T> t
deliveredResponseSink.complete();
}
else {
deliveredResponseSink.next(this.transport.unmarshalFrom(jsonRpcResponse.result(), typeRef));
var result = jsonRpcResponse.result();
var unmarshalled = this.transport.unmarshalFrom(result, typeRef);
// https://github.com/modelcontextprotocol/java-sdk/issues/605
if (unmarshalled != null)
deliveredResponseSink.next(unmarshalled);
else
// NB: next() cannot be called with null
deliveredResponseSink
.error(new IllegalStateException("Failed to unmarshal response result: " + result));
}
}
});
Expand Down
Loading