Skip to content

Extract BaseSession request ID increment logic #1102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ronmrdechai
Copy link

See title

Motivation and Context

This allows the request ID increment logic to be overwritten by
subclasses. I have a unique need to share sessions' underlying input
and output streams, but not the sessions themselves. This would require
keeping track of request IDs globally to avoid overlap.

Having this logic overridable lets me do that.

How Has This Been Tested?

CI

Breaking Changes

N/A

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

N/A

This allows the request ID increment logic to be overwritten by
subclasses. I have a unique need to share sessions' underlying input
and output streams, but not the sessions themselves. This would require
keeping track of request IDs globally to avoid overlap.

Having this logic overridable lets me do that.
@ronmrdechai
Copy link
Author

For reference, the way I've worked around this currently is that I added these two methods to a subclass of BaseSession:

class MySession(ClientSession):
    _global_request_id: int = 1

    @override
    @property
    def _request_id(self) -> int:
        """
        This setter/getter pair ensures request IDs are globally unique for the
        lifetime of the process. Client session channels for the same MCP server
        are shared, so tracking the request ID globally is required.
        """
        return MySession._global_request_id
​​​
    @_request_id.setter
    def _request_id(self, value: int) -> None:
        diff = value - MySession._global_request_id
        MySession._global_request_id += diff

This is obviously brittle and I'd like a proper interface for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant