Avoiding to parse string arguments containing valid JSON if the argument annotation is str #1113
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Every time a parameter of a tool is passed as a string containing a valid JSON it is parsed and replaced. From the comment of pre_parse_json() "This is to handle cases like
["a", "b", "c"]
being passed in as JSON inside a string rather than an actual list"Nevertheless this method doesn't check if the annotation of parameters indicates that it is supposed to be a str rather than a dict or a list
Types of changes
Checklist