Skip to content

feat: Adjust log levels for trace logging #350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kyle-leonhard
Copy link
Contributor

Reduce log levels on per-connection/request/message events to trace from info.

I considered using DEBUG which is the default level used by Axum for request logging. WDYT?

Motivation and Context

Emitting per-connection and message logs at INFO level is unexpected, in my experience. Using a finer level allows filtering to be effective without requiring users to set module level configuration.

How Has This Been Tested?

Locally with my MCP server

Breaking Changes

None

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

None

@github-actions github-actions bot added T-core Core library changes T-handler Handler implementation changes T-transport Transport layer changes labels Aug 4, 2025
@kyle-leonhard kyle-leonhard changed the title Adjust log levels for trace logging feat: Adjust log levels for trace logging Aug 4, 2025
@jokemanfire
Copy link
Collaborator

I'm not sure if the level of these logs needs to be lowered. What's your opinion? @4t145

@4t145
Copy link
Collaborator

4t145 commented Aug 12, 2025

Sorry for late response

Using a finer level allows filtering to be effective without requiring users to set module level configuration.

Current log level are base on the following standards

  • session/connection level: info
  • reqeust/message level: debug
  • more verbose log: trace

I don't think set all level to trace could be "finer", there are more logs during the connect/request, if they are all in trace level, it would be inconvenient to distinguish them. I think the debug level could be OK. But after all, set module level configuration won't cost you a lot of time. So I am not going to close this pr and maybe more people can give me some suggestion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-core Core library changes T-handler Handler implementation changes T-transport Transport layer changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants