Skip to content

Upgrade to Node LTS #1072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Nov 7, 2025
+19 −3
Merged

Upgrade to Node LTS #1072

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
3618a89
feat: update node versions
mattzcarey Nov 3, 2025
337cb35
update engines to lts
mattzcarey Nov 3, 2025
d8bd06a
revert engines
mattzcarey Nov 3, 2025
1912059
Update package.json
mattzcarey Nov 4, 2025
242b32a
Merge branch 'main' into update-node
mattzcarey Nov 7, 2025
8ce78bf
fix: ci
mattzcarey Nov 7, 2025
ae39978
Merge branch 'main' of https://github.com/modelcontextprotocol/typesc…
mattzcarey Nov 7, 2025
268984b
Merge branch 'main' into update-node
mattzcarey Nov 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 20 additions & 4 deletions .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,19 +18,35 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version: 18
node-version: 24
cache: npm

- run: npm ci
- run: npm run build
- run: npm test
- run: npm run lint

test:
runs-on: ubuntu-latest
strategy:
fail-fast: false
matrix:
node-version: [18, 24]

steps:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version: ${{ matrix.node-version }}
cache: npm

- run: npm ci
- run: npm test

publish:
runs-on: ubuntu-latest
if: github.event_name == 'release'
environment: release
needs: build
needs: [build, test]

permissions:
contents: read
Expand All @@ -40,7 +56,7 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version: 18
node-version: 24
cache: npm
registry-url: 'https://registry.npmjs.org'

Expand Down
3 changes: 2 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,8 @@
"url": "git+https://github.com/modelcontextprotocol/typescript-sdk.git"
},
"engines": {
"node": ">=18"
"node": ">=18",
"npm": ">=10"
Copy link
Contributor

@felixweinberger felixweinberger Nov 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the NPM upgrade intentional? Apparently node 18 ships with older npm versions, might be an inadvertently breaking change?

Copy link
Contributor Author

@mattzcarey mattzcarey Nov 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought it shipped with 10+ but yep I'm wrong. Will remove:

  {
    "version": "v18.0.0",
    "date": "2022-04-18",
    "files": [
      "aix-ppc64",
      "headers",
      "linux-arm64",
      "linux-armv7l",
      "linux-ppc64le",
      "linux-s390x",
      "linux-x64",
      "osx-arm64-tar",
      "osx-x64-pkg",
      "osx-x64-tar",
      "src",
      "win-x64-7z",
      "win-x64-exe",
      "win-x64-msi",
      "win-x64-zip"
    ],
    "npm": "8.6.0",
    "v8": "10.1.124.8",
    "uv": "1.43.0",
    "zlib": "1.2.11",
    "openssl": "3.0.2+quic",
    "modules": "108",
    "lts": false,
    "security": false
  },

},
"keywords": [
"modelcontextprotocol",
Expand Down