Upgrade local node version to v20.10.0 #282
Open
+2
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ihrpr
requested changes
Jun 27, 2025
| @@ -12,7 +12,7 @@ | |||
| "url": "git+https://github.com/modelcontextprotocol/typescript-sdk.git" | |||
| }, | |||
| "engines": { | |||
| "node": ">=18" | |||
| "node": ">=20.10.0" | |||
There was a problem hiding this comment.
Suggested change
| "node": ">=20.10.0" | |
| "node": ">=18.17.0" |
There was a problem hiding this comment.
@ihrpr According to MDN's URL.canParse docs, its introduced in 19.9 so it'd need that version. Am I misunderstanding the docs?
There was a problem hiding this comment.
https://nodejs.org/en/blog/release/v18.17.0
url:
(SEMVER-MINOR) implement URL.canParse (Matthew Aitken) #47179
There was a problem hiding this comment.
in case it's useful, I was testing it in #706
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Updates the locally required node version to v20.10.0 because there are many dependencies in the project on Node features in v20 and above. For example, Running
npm run teston a fresh install currently fails with many errors includingURL.canParse is not a function(the method was added in v19.9)How Has This Been Tested?
npm run testnow passes on fresh install of the repoBreaking Changes
No breaking changes
Types of changes
Checklist
Additional context