Skip to content

Conversation

FeldrinH
Copy link
Contributor

@FeldrinH FeldrinH commented Aug 23, 2025

This PR attempts to fix a few issues with version selection when installing projects (especially data packs) in Modrinth App and filtering when browsing mod versions for a specific instance/profile.

Primarily fixes #3538 and unifies related logic, but as a side effect fixes a few other issues for which I did not find open tickets.

The changes are:

  • Installing projects and their dependencies now both use the same logic to select a compatible version to install:
    • Version must support game version of the instance.
    • If the project is a mod then version must use a compatible modloader or be a datapack. If you are using a modloader and a version for that modloader is available then it is preferred over the datapack. (My assumption here is that the modloader version is just the datapack packaged for that modloader and if you are using a modloader then you want the modloader packaged version rather than the raw datapack.)
    • If the project is not a mod then all versions are considered compatible regardless of the supported loader(s).
  • As a result of this, automatic dependency installation can now install resource packs, shaders, and other non-mod projects.
  • Automatic filters applied to the displayed version list match the version selection logic used when installing. Previously filters for shaders, data packs and resource packs were completely broken and would filter out all versions.
  • When installing a specific version through the discover content tab it would prompt you to select an instance and then always install the latest version. This has been fixed so it now installs the specific version you selected.

Open questions:

  • Previously automatic dependency installation could not install resource packs, shaders, and other non-mod projects. Was there a reason for this restriction or was it just a bug?
  • Is preferring modloader versions over datapack versions the correct behavior for mods that have both? downloading datapacks with mod versions prioritizes the mod download over datapack #3972 argues that it is not, but I am not sure what a good alternative would be.

@IMB11 IMB11 self-requested a review August 24, 2025 16:47
Copy link
Member

@IMB11 IMB11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, LGTM.

@IMB11 IMB11 enabled auto-merge August 27, 2025 10:26
@IMB11 IMB11 added enhancement New feature or request app Relates to Modrinth App frontend labels Aug 27, 2025
@IMB11
Copy link
Member

IMB11 commented Aug 27, 2025

@FeldrinH Please fix the lint issues - pnpm run fix within the app-frontend folder.

auto-merge was automatically disabled August 27, 2025 13:23

Head branch was pushed to by a user without write access

@FeldrinH
Copy link
Contributor Author

Please fix the lint issues - pnpm run fix within the app-frontend folder.

Done. It also changed some files that were not touched by this PR. I did not commit those.

@IMB11 IMB11 enabled auto-merge August 27, 2025 13:39
@IMB11 IMB11 added this pull request to the merge queue Aug 27, 2025
Merged via the queue into modrinth:main with commit a2c07c9 Aug 27, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app Relates to Modrinth App enhancement New feature or request frontend
Development

Successfully merging this pull request may close these issues.

Datapacks are flagged as incompatible with vanilla platform because they use a wrong platform data type
2 participants