Skip to content

Hide hints about land option when it's disabled #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ZolotukhinM merged 1 commit into from
Dec 4, 2025
Merged

Hide hints about land option when it's disabled #110

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 14 additions & 4 deletions src/stack_pr/cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -903,9 +903,10 @@ class CommonArgs:
verbose: bool
branch_name_template: str
show_tips: bool
land_disabled: bool

@classmethod
def from_args(cls, args: argparse.Namespace) -> CommonArgs:
def from_args(cls, args: argparse.Namespace, *, land_disabled: bool) -> CommonArgs:
return cls(
args.base,
args.head,
Expand All @@ -915,6 +916,7 @@ def from_args(cls, args: argparse.Namespace) -> CommonArgs:
args.verbose,
args.branch_name_template,
args.show_tips,
land_disabled,
)


Expand Down Expand Up @@ -996,6 +998,7 @@ def deduce_base(args: CommonArgs) -> CommonArgs:
args.verbose,
args.branch_name_template,
args.show_tips,
args.land_disabled,
)


Expand All @@ -1009,7 +1012,8 @@ def print_tips_after_export(st: list[StackEntry], args: CommonArgs) -> None:
top_commit = get_current_branch_name()

log(b("\nOnce the stack is reviewed, it is ready to land!"), level=1)
log(LAND_STACK_TIP.format(**locals()))
if not args.land_disabled:
log(LAND_STACK_TIP.format(**locals()))


# ===----------------------------------------------------------------------=== #
Expand Down Expand Up @@ -1409,7 +1413,8 @@ def print_tips_after_view(st: list[StackEntry], args: CommonArgs) -> None:
if ready_to_land:
log(b("\nThis stack is ready to land!"))
log(UPDATE_STACK_TIP.format(**locals()))
log(LAND_STACK_TIP.format(**locals()))
if not args.land_disabled:
log(LAND_STACK_TIP.format(**locals()))
return

# Stack is not ready to land, suggest exporting it first
Expand Down Expand Up @@ -1651,7 +1656,12 @@ def main() -> None: # noqa: PLR0912

# Make sure "$ID" is present in the branch name template and append it if not
args.branch_name_template = fix_branch_name_template(args.branch_name_template)
common_args = CommonArgs.from_args(args)
common_args = CommonArgs.from_args(
args,
land_disabled=(
config.get("land", "style", fallback="bottom-only") == "disable"
),
)

if common_args.verbose:
logger.setLevel(logging.DEBUG)
Expand Down
Loading