add closed caption color token #162
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NotNestor
reviewed
Mar 8, 2022
components/closed-caption.json
Outdated
| "button-dark": { | ||
| "#normal": { | ||
| "background": "@theme-common-control-closedcaption-button-dark-normal", | ||
| "text": "@theme-common-control-closedcaption-text-dark", |
Collaborator
There was a problem hiding this comment.
all these tokens are incorrect and this will not auto generate
NotNestor
reviewed
Mar 8, 2022
components/closed-caption.json
Outdated
| "comment": "", | ||
| "figma": "https://www.figma.com/file/NaNrfXjygZtRgMfHAFHjsp/Components---Windows?node-id=40865%3A50204", | ||
| "background-light": "@theme-common-control-closedcaption-background-light", | ||
| "background-dark": "@theme-common-control-closedcaption-background-dark", |
Collaborator
There was a problem hiding this comment.
we don't specify background light and dark. Just a background colour and the correct colour will be selected based on the thme
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Guide
UX has add the close caption to the library.
https://www.figma.com/file/NaNrfXjygZtRgMfHAFHjsp/Components---Windows?node-id=40865%3A50204
Add the color token for the control.
Note:
These. color are not change when theme change.
In each, user can changed the color of the closed caption box