feat: allow PHP 8.4, temp remove Vimeo #801
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
I am willing to pull some PR to a different branch in this project and then release an alpha/beta/RC version (4.6.0-xxx). Would that help? |
Contributor
Author
|
I guess that would help |
Contributor
|
For me, it doesn't make a difference. I currently pin to my fork. Pinning to an alpha tag wouldn't be much of a difference. One pragmatic solution could be: #796 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#796
@ruudk @frederikbosch
Could you please have a look if this is a solution for a pre-release to help People to move on with PHP 8.4 ?
There is one Deprecation about a vendor-library. but this needs to be fixed there.
Swap\Swap::quote(): Implicitly marking parameter $date as nullable is deprecated, the explicit nullable type must be used instead