Skip to content

Conversation

mcmorisi
Copy link
Collaborator

@mcmorisi mcmorisi commented Nov 25, 2024

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-44180

Staging Links

  • fundamentals/serialization/poco
  • Self-Review Checklist

    • Is this free of any warnings or errors in the RST?
    • Did you run a spell-check?
    • Did you run a grammar-check?
    • Are all the links working?
    • Are the facets and meta keywords accurate?

    Copy link

    netlify bot commented Nov 25, 2024

    Deploy Preview for mongodb-docs-csharp ready!

    Name Link
    🔨 Latest commit 2e984d0
    🔍 Latest deploy log https://app.netlify.com/sites/mongodb-docs-csharp/deploys/6745db720854d40008c823f8
    😎 Deploy Preview https://deploy-preview-323--mongodb-docs-csharp.netlify.app
    📱 Preview on mobile
    Toggle QR Code...

    QR Code

    Use your smartphone camera to open QR code link.

    To edit notification comments on pull requests, go to your Netlify site configuration.

    @mcmorisi mcmorisi marked this pull request as ready for review November 25, 2024 21:51
    Copy link
    Collaborator

    @lindseymoore lindseymoore left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    LGTM w/ suggestion!

    Comment on lines 261 to 262
    The ``_id`` field mapping logic described in this section only applies to the
    root document, and does not apply to nested documents.
    Copy link
    Collaborator

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Suggested change
    The ``_id`` field mapping logic described in this section only applies to the
    root document, and does not apply to nested documents.
    The ``_id`` field mapping logic described in this section only applies to the
    root document and does not apply to nested documents.

    S: Just to get rid of the implied 'it'

    @mcmorisi mcmorisi merged commit 73e4e14 into mongodb:master Nov 26, 2024
    5 of 6 checks passed
    @mcmorisi mcmorisi deleted the DOCSP-44180-nested-ids branch November 26, 2024 14:36
    mcmorisi added a commit that referenced this pull request Nov 26, 2024
    mcmorisi added a commit that referenced this pull request Nov 26, 2024
    mcmorisi added a commit that referenced this pull request Nov 26, 2024
    mcmorisi added a commit that referenced this pull request Nov 26, 2024
    mcmorisi added a commit that referenced this pull request Nov 26, 2024
    mcmorisi added a commit that referenced this pull request Nov 26, 2024
    mcmorisi added a commit that referenced this pull request Nov 26, 2024
    mcmorisi added a commit that referenced this pull request Nov 26, 2024
    mcmorisi added a commit that referenced this pull request Nov 26, 2024
    mcmorisi added a commit that referenced this pull request Nov 26, 2024
    mongoKart pushed a commit to mongoKart/docs-csharp that referenced this pull request May 16, 2025
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Labels

    None yet

    Projects

    None yet

    Development

    Successfully merging this pull request may close these issues.

    2 participants