Skip to content

Conversation

mcmorisi
Copy link
Collaborator

@mcmorisi mcmorisi commented Dec 5, 2024

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-45807

Staging Links

  • whats-new
  • Self-Review Checklist

    • Is this free of any warnings or errors in the RST?
    • Did you run a spell-check?
    • Did you run a grammar-check?
    • Are all the links working?
    • Are the facets and meta keywords accurate?

    Copy link

    netlify bot commented Dec 5, 2024

    Deploy Preview for mongodb-docs-csharp ready!

    Name Link
    🔨 Latest commit c924a2c
    🔍 Latest deploy log https://app.netlify.com/sites/mongodb-docs-csharp/deploys/67520384cbd81200087ef2de
    😎 Deploy Preview https://deploy-preview-347--mongodb-docs-csharp.netlify.app
    📱 Preview on mobile
    Toggle QR Code...

    QR Code

    Use your smartphone camera to open QR code link.

    To edit notification comments on pull requests, go to your Netlify site configuration.

    @mcmorisi mcmorisi marked this pull request as ready for review December 5, 2024 18:56
    Copy link
    Collaborator

    @jordan-smith721 jordan-smith721 left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    A couple quick fixes, otherwise LGTM

    namespace. The driver can now serialize ``ImmutableArray`` objects, and serialization
    for other immutable collections is more memory efficient.

    - Adds support for the token field time and array field expressions with Atlas Search
    Copy link
    Collaborator

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Suggested change
    - Adds support for the token field time and array field expressions with Atlas Search
    - Adds support for the token field type and array field expressions with Atlas Search

    Copy link
    Collaborator Author

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    🤦 good catch

    Comment on lines 56 to 57
    - Adds support for the ``Exists``, ``IsMissing``, and ``IsNullOrMissing`` methods
    in MQL queries.
    Copy link
    Collaborator

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    We don't externally refer to "MQL" anymore:

    Suggested change
    - Adds support for the ``Exists``, ``IsMissing``, and ``IsNullOrMissing`` methods
    in MQL queries.
    - Adds support for the ``Exists``, ``IsMissing``, and ``IsNullOrMissing`` methods
    in MongoDB Query API filters.

    @mcmorisi mcmorisi merged commit c8b5575 into mongodb:master Dec 5, 2024
    5 of 6 checks passed
    @mcmorisi mcmorisi deleted the v3.1 branch December 5, 2024 19:48
    mongoKart pushed a commit to mongoKart/docs-csharp that referenced this pull request May 16, 2025
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Labels

    None yet

    Projects

    None yet

    Development

    Successfully merging this pull request may close these issues.

    2 participants