Skip to content

Conversation

@mayaraman19
Copy link
Collaborator

@mayaraman19 mayaraman19 commented Dec 12, 2024

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-40066

Staging Links

Self-Review Checklist

  • Is this free of any warnings or errors in the RST?
  • Did you run a spell-check?
  • Did you run a grammar-check?
  • Are all the links working?
  • Are the facets and meta keywords accurate?

@netlify
Copy link

netlify bot commented Dec 12, 2024

Deploy Preview for mongodb-docs-csharp ready!

Name Link
🔨 Latest commit 6d4c117
🔍 Latest deploy log https://app.netlify.com/sites/mongodb-docs-csharp/deploys/67647f3fcae31b0008133b5a
😎 Deploy Preview https://deploy-preview-373--mongodb-docs-csharp.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@norareidy norareidy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a couple questions, let me know if anything's unclear!

Copy link
Collaborator

@norareidy norareidy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM + small suggestion

@mayaraman19 mayaraman19 requested review from a team and papafe and removed request for a team December 13, 2024 20:54
@mayaraman19 mayaraman19 requested a review from papafe December 18, 2024 21:36
Copy link

@papafe papafe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@norareidy norareidy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a few final thoughts!

You can chain or nest ``Select`` and ``SelectMany`` statements to unwind nested
arrays. Consider a collection that contains documents with a **new** schema. These
documents contain a ``restaurants`` field, which holds an array of documents
that each represent the ``Restaurant`` class. The documents within the array each have
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

S: since the classes model the documents, I think it's more accurate to say the document is "represented by" Restaurants, rather than represent Restaurants

Suggested change
that each represent the ``Restaurant`` class. The documents within the array each have
represented by the ``Restaurant`` class. The documents within the array each have

Comment on lines 330 to 331
a ``grades`` field that holds an array of documents that each represent
the ``Grade`` class. The following code is an example of a single document in
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

S: same suggestion as above

Suggested change
a ``grades`` field that holds an array of documents that each represent
the ``Grade`` class. The following code is an example of a single document in
a ``grades`` field that holds an array of documents represented by
the ``Grade`` class. The following code is an example of a single document in

:visible: false
:language: json

// output for first document in collection
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Q: should this be the first restaurant instead? since these are just the grades for Tov Kosher Kitchen, but the first guidebook document would have more restaurants

Suggested change
// output for first document in collection
// output for first restaurant

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, it should be first document - I will make the example/output more clear

@mayaraman19 mayaraman19 merged commit 8c2bdc5 into mongodb:master Dec 19, 2024
6 checks passed
@mayaraman19 mayaraman19 deleted the DOCSP-40066 branch December 19, 2024 20:23
github-actions bot pushed a commit that referenced this pull request Dec 19, 2024
github-actions bot pushed a commit that referenced this pull request Dec 19, 2024
github-actions bot pushed a commit that referenced this pull request Dec 19, 2024
github-actions bot pushed a commit that referenced this pull request Dec 19, 2024
github-actions bot pushed a commit that referenced this pull request Dec 19, 2024
github-actions bot pushed a commit that referenced this pull request Dec 19, 2024
github-actions bot pushed a commit that referenced this pull request Dec 19, 2024
mongoKart pushed a commit to mongoKart/docs-csharp that referenced this pull request Dec 20, 2024
mongoKart pushed a commit to mongoKart/docs-csharp that referenced this pull request May 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants