-
Notifications
You must be signed in to change notification settings - Fork 26
DOCSP-40066: Support SelectMany inside Project/Select #373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for mongodb-docs-csharp ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a couple questions, let me know if anything's unclear!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM + small suggestion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with a few final thoughts!
source/fundamentals/linq.txt
Outdated
| You can chain or nest ``Select`` and ``SelectMany`` statements to unwind nested | ||
| arrays. Consider a collection that contains documents with a **new** schema. These | ||
| documents contain a ``restaurants`` field, which holds an array of documents | ||
| that each represent the ``Restaurant`` class. The documents within the array each have |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
S: since the classes model the documents, I think it's more accurate to say the document is "represented by" Restaurants, rather than represent Restaurants
| that each represent the ``Restaurant`` class. The documents within the array each have | |
| represented by the ``Restaurant`` class. The documents within the array each have |
source/fundamentals/linq.txt
Outdated
| a ``grades`` field that holds an array of documents that each represent | ||
| the ``Grade`` class. The following code is an example of a single document in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
S: same suggestion as above
| a ``grades`` field that holds an array of documents that each represent | |
| the ``Grade`` class. The following code is an example of a single document in | |
| a ``grades`` field that holds an array of documents represented by | |
| the ``Grade`` class. The following code is an example of a single document in |
| :visible: false | ||
| :language: json | ||
|
|
||
| // output for first document in collection |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Q: should this be the first restaurant instead? since these are just the grades for Tov Kosher Kitchen, but the first guidebook document would have more restaurants
| // output for first document in collection | |
| // output for first restaurant |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope, it should be first document - I will make the example/output more clear
(cherry picked from commit 8c2bdc5)
(cherry picked from commit 8c2bdc5)
(cherry picked from commit 8c2bdc5)
(cherry picked from commit 8c2bdc5)
(cherry picked from commit 8c2bdc5)
(cherry picked from commit 8c2bdc5)
(cherry picked from commit 8c2bdc5)
Pull Request Info
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-40066
Staging Links
Self-Review Checklist