-
Couldn't load subscription status.
- Fork 26
DOCSP-45429: sort for update and replace one #581
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOCSP-45429: sort for update and replace one #581
Conversation
✅ Deploy Preview for docs-csharp ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
| **Data Type:** ``bool`` | ||
|
|
||
| * - ``Sort`` | ||
| - Specifies a sort order to apply to documents before the server |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is not totally correct because I'm not sure if the collection gets sorted before/after the match is done. We should try to be more generic, just saying that if there are multiple matches to the query, the sort order is used to decide which document will be updated/replaced. This comment is also valid for the other page.
Here it's explained as a parameter: https://www.mongodb.com/docs/manual/reference/method/db.collection.updateOne/#parameters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The sort order needs a slightly different wording.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* DOCSP-45429: sort for update and replace one * FP tech review 1 (cherry picked from commit f6d5c03)
* DOCSP-45429: sort for update and replace one * FP tech review 1 (cherry picked from commit f6d5c03)
* DOCSP-45429: sort for update and replace one * FP tech review 1 (cherry picked from commit f6d5c03)
* DOCSP-45429: sort for update and replace one * FP tech review 1
Pull Request Info
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-45429
Staging Links
Self-Review Checklist