Skip to content

Conversation

@rustagir
Copy link
Contributor

@rustagir rustagir commented Apr 8, 2025

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-45429

Staging Links

  1. update
  2. replace
  3. whats new

Self-Review Checklist

  • Is this free of any warnings or errors in the RST?
  • Did you run a spell-check?
  • Did you run a grammar-check?
  • Are all the links working?
  • Are the facets and meta keywords accurate?
  • Are the page titles greater than 20 characters long and SEO relevant?

@netlify
Copy link

netlify bot commented Apr 8, 2025

Deploy Preview for docs-csharp ready!

Name Link
🔨 Latest commit 7bd924e
🔍 Latest deploy log https://app.netlify.com/sites/docs-csharp/deploys/67fe75ec3ec7f30008ba0c44
😎 Deploy Preview https://deploy-preview-581--docs-csharp.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@stephmarie17 stephmarie17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rustagir rustagir requested a review from papafe April 10, 2025 13:45
**Data Type:** ``bool``

* - ``Sort``
- Specifies a sort order to apply to documents before the server
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is not totally correct because I'm not sure if the collection gets sorted before/after the match is done. We should try to be more generic, just saying that if there are multiple matches to the query, the sort order is used to decide which document will be updated/replaced. This comment is also valid for the other page.

Here it's explained as a parameter: https://www.mongodb.com/docs/manual/reference/method/db.collection.updateOne/#parameters

Copy link

@papafe papafe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The sort order needs a slightly different wording.

@rustagir rustagir requested a review from papafe April 15, 2025 15:04
Copy link

@papafe papafe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rustagir rustagir merged commit f6d5c03 into mongodb:master Apr 16, 2025
6 checks passed
rustagir added a commit that referenced this pull request Apr 16, 2025
* DOCSP-45429: sort for update and replace one

* FP tech review 1

(cherry picked from commit f6d5c03)
rustagir added a commit that referenced this pull request Apr 16, 2025
* DOCSP-45429: sort for update and replace one

* FP tech review 1

(cherry picked from commit f6d5c03)
rustagir added a commit that referenced this pull request Apr 16, 2025
* DOCSP-45429: sort for update and replace one

* FP tech review 1

(cherry picked from commit f6d5c03)
mongoKart pushed a commit to mongoKart/docs-csharp that referenced this pull request May 16, 2025
* DOCSP-45429: sort for update and replace one

* FP tech review 1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants