[LG-5463] fix(code): fix language select rendering when displayName and language differ #3075
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hing either its display name or language value.
🦋 Changeset detectedLatest commit: ebabcbe The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug in the Code component where the language select wouldn't render when the displayName and language properties differed in language options. The fix updates the Panel component's language matching logic to check both properties instead of only displayName.
- Updates language matching logic in Panel component to check both
displayNameandlanguageproperties - Adds comprehensive test coverage for both matching and differing displayName/language scenarios
- Centralizes language options configuration by moving it to test utilities
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
packages/code/src/Panel/Panel.tsx |
Updated currentLanguage finder to match against both displayName and language properties |
packages/code/src/testing/Code.testutils.tsx |
Added new language option with differing displayName ("macOS") and language ("shell") |
packages/code/src/Code/Code.spec.tsx |
Added comprehensive test cases for both matching and differing displayName/language scenarios |
packages/code/src/LanguageSwitcher/LanguageSwitcherExample.tsx |
Refactored to use centralized language options and added shell snippet support |
packages/code/src/Code.stories.tsx |
Updated import to use centralized language options from test utilities |
packages/code/src/testing/getTestUtils.spec.tsx |
Updated test expectation to account for additional language option |
.changeset/flat-carrots-change.md |
Added changeset documentation explaining the bug fix |
|
Size Change: +48 B (0%) Total Size: 2.01 MB
ℹ️ View Unchanged
|
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✍️ Proposed changes
Fixes a bug in the Code component that prevented the language select from rendering when the
displayNameandlanguageproperties differed in the language options. The issue was in the Panel component's logic for finding the current language, which only matched againstdisplayNamebut not against thelanguageproperty itself.The fix updates the language matching logic to check both
displayNameandlanguageproperties, enabling proper rendering of the language selector in cases where these values differ (e.g., displayName: "macOS", language: "shell").🎟️ Jira ticket: LG-5463
✅ Checklist
pnpm changesetand documented my changes🧪 How to test changes
Story
View the
With Language SwitcherstoryManually
displayNameandlanguagediffer:languagevalue (not displayName):Code.spec.tsxto verify the fix works for both matching and differing displayName/language scenarios