chore(TS) Include .spec files in tsconfig
#3076
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 63d8c43 The changes in this PR will be included in the next version bump. This PR includes changesets to release 112 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Pull Request Overview
This PR updates TypeScript configuration files across the LeafyGreen UI monorepo to include .spec files in the build process, ensuring that type tests are type-checked at build time. The change removes the "**/*.spec.*" exclusion pattern from tsconfig.json files across 100+ packages.
- Removes TypeScript exclusion of
.specfiles from all package configurations - Updates existing spec files to address newly surfaced TypeScript errors
- Adds missing dependencies and references to support spec file type checking
Reviewed Changes
Copilot reviewed 114 out of 115 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
Multiple tsconfig.json files |
Remove "**/*.spec.*" from exclude patterns to enable type checking of test files |
Various .spec.tsx files |
Fix TypeScript errors exposed by including spec files in compilation |
packages/hooks/package.json |
Add missing test renderer dependencies for spec file compilation |
packages/icon/tsconfig.json |
Include additional script files and add lib reference |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
TheSonOfThomp
commented
Aug 26, 2025
| @@ -100,7 +100,7 @@ describe('packages/icon-button', () => { | |||
| }); | |||
|
|
|||
| test('requires either aria-label or aria-labelledby', () => { | |||
| /// @ts-expect-error | |||
| // FIXME: // @ts-expect-error - aria-label or aria-labelledby is required | |||
There was a problem hiding this comment.
TheSonOfThomp
commented
Aug 26, 2025
| @@ -104,7 +104,7 @@ describe('packages/info-sprinkle', () => { | |||
| // eslint-disable-next-line jest/no-disabled-tests | |||
| test.skip('types behave as expected', () => { | |||
| <> | |||
| {/* @ts-expect-error - Missing children */} | |||
| {/* FIXME: add expect error @ts-expect-error - Missing children */} | |||
There was a problem hiding this comment.
shaneeza
reviewed
Aug 27, 2025
| type AnchorLikeProps = InferredPolymorphicProps<'a', BaseLinkProps>; | ||
|
|
||
| type LinkRenderProps = SpanLikeProps | AnchorLikeProps; | ||
| type LinkRenderProps = InferredPolymorphicProps<'span', BaseLinkProps>; |
There was a problem hiding this comment.
Can we get away with this, because if href is defined, the component props are set to a element props, and span is ignored?
There was a problem hiding this comment.
That's by design. If we define href we want to use a props not span props
tsck
reviewed
Aug 27, 2025
| @@ -12,6 +12,8 @@ const addChartSeries = jest.fn(); | |||
| const ChartProviderMock = ({ children }: PropsWithChildren<{}>) => { | |||
| return ( | |||
| <ChartContext.Provider | |||
| // TODO: Fix this test context @tsck | |||
There was a problem hiding this comment.
👍 Will fix this once it's merged - https://jira.mongodb.org/browse/LG-5478
shaneeza
approved these changes
Aug 28, 2025
|
Size Change: -1 B (0%) Total Size: 2.01 MB
ℹ️ View Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding
.specfiles to the tsconfig ensures that any type tests get type checked at build-time.Updates spec files to resolve TS issues where the solution is simple.
Adds
FIXMEcomments where types in spec files were already brokenNext steps: Type check spec & story files only on
testrun (not everybuild)This will slow down builds somewhat in the short term