[LG-5129] feat(code-editor): add undo/redo functionality #3063 #3091
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Implemented handleUndo and handleRedo methods to allow users to undo and redo editor actions. - Updated CodeEditorHandle interface to include undo and redo methods, enhancing the editor's capabilities. - Improved user experience by providing feedback when undo/redo actions are unavailable.
- Introduced undo and redo functions in the CodeEditorContext to enhance user interaction. - Updated the CodeEditor component to integrate these new functionalities, improving the overall editing experience.
- Added handleUndoClick and handleRedoClick methods to the Panel component to utilize the new undo and redo functions from the CodeEditorContext. - Updated the onClick handlers for the Undo and Redo menu items to call the new methods, enhancing user interaction and experience.
- Added tests for undo and redo functionalities in the CodeEditor component, ensuring they work correctly with content changes. - Enhanced test utilities to include getContent, undo, and redo methods, providing a more comprehensive testing framework for the editor. - Updated the Panel component tests to verify the integration of undo and redo actions in the user interface, improving overall test coverage.
- Updated the imperative handle test to expose a complete API, including methods for undo, redo, getContents, formatCode, and getEditorViewInstance. - Added a new utility function, getHandle, to retrieve the editor handle instance for testing imperative methods. - Modified the insertText function to default to inserting text at the end of the document, improving usability in tests.
- Updated the README to clarify the various methods for formatting code in the CodeEditor, emphasizing the programmatic access through the CodeEditor ref. - Introduced a new section detailing the imperative API, including methods for content manipulation, formatting, and undo/redo operations. - Added examples for using the imperative methods, improving the documentation for developers. - Adjusted the formatting options description to enhance clarity and usability.
- Moved `codeSnippets` to a dedicated testing file for better organization and accessibility. - Updated import paths in the CodeEditor stories and specs to reflect the new location of `codeSnippets`. - Introduced comprehensive test utilities for CodeMirror extension hooks, enhancing the testing framework's capabilities.
…nent - Introduced `renderPanel` function to facilitate rendering of the Panel component with necessary context for testing. - Added `PanelSelectors` for consistent access to panel elements in tests. - Implemented various interaction methods for testing user interactions with the Panel, including format and copy button actions. - Enhanced README documentation to include new testing utilities and examples for better guidance on testing Panel interactions.
- Changed import paths in various extension spec files to reflect the new location of testing utilities, improving organization and accessibility. - Ensured consistency across all extension tests by standardizing the import structure.
…ality - Changed references from `modules` to `coreModules` in the `handleUndo` and `handleRedo` functions to align with the updated module loading structure. - Improved code clarity and maintainability by ensuring consistent usage of the core modules for command handling.
- Renamed mock functions to default stub functions for clarity in the CodeEditor context. - Updated the README to reflect changes in the testing utilities, including new context configuration options for overriding default functions in tests. - Enhanced test cases to utilize the new stub functions, improving consistency and maintainability in testing the Panel component.
…ests - Reorganized import statements in the useIndentExtension.spec.ts file to improve clarity and maintainability. - Moved the IndentUnits import to align with the updated structure of testing utilities.
…ions - Removed the use of mockPanelFunctions in Panel tests, replacing them with defaultPanelContextFunctions for improved clarity and consistency. - Updated test cases to directly utilize context configuration for undo and redo actions, enhancing maintainability and readability of the tests.
🦋 Changeset detectedLatest commit: 25bcc9e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
shaneeza
approved these changes
Aug 28, 2025
|
Size Change: +246 B (+0.01%) Total Size: 2.07 MB
ℹ️ View Unchanged
|
tsck
added a commit
that referenced
this pull request
Aug 29, 2025
* feat(CodeEditor): add undo and redo functionality to the editor - Implemented handleUndo and handleRedo methods to allow users to undo and redo editor actions. - Updated CodeEditorHandle interface to include undo and redo methods, enhancing the editor's capabilities. - Improved user experience by providing feedback when undo/redo actions are unavailable. * feat(CodeEditor): add undo and redo methods to context and editor - Introduced undo and redo functions in the CodeEditorContext to enhance user interaction. - Updated the CodeEditor component to integrate these new functionalities, improving the overall editing experience. * feat(Panel): integrate undo and redo functionality in the editor panel - Added handleUndoClick and handleRedoClick methods to the Panel component to utilize the new undo and redo functions from the CodeEditorContext. - Updated the onClick handlers for the Undo and Redo menu items to call the new methods, enhancing user interaction and experience. * feat(CodeEditor): implement undo and redo methods in tests and utilities - Added tests for undo and redo functionalities in the CodeEditor component, ensuring they work correctly with content changes. - Enhanced test utilities to include getContent, undo, and redo methods, providing a more comprehensive testing framework for the editor. - Updated the Panel component tests to verify the integration of undo and redo actions in the user interface, improving overall test coverage. * feat(CodeEditor): enhance imperative handle API and testing utilities - Updated the imperative handle test to expose a complete API, including methods for undo, redo, getContents, formatCode, and getEditorViewInstance. - Added a new utility function, getHandle, to retrieve the editor handle instance for testing imperative methods. - Modified the insertText function to default to inserting text at the end of the document, improving usability in tests. * feat(CodeEditor): enhance documentation and add imperative API details - Updated the README to clarify the various methods for formatting code in the CodeEditor, emphasizing the programmatic access through the CodeEditor ref. - Introduced a new section detailing the imperative API, including methods for content manipulation, formatting, and undo/redo operations. - Added examples for using the imperative methods, improving the documentation for developers. - Adjusted the formatting options description to enhance clarity and usability. * changeset * chore: remove obsolete clever-editors-undo changeset file * refactor(CodeEditor): reorganize testing utilities - Moved `codeSnippets` to a dedicated testing file for better organization and accessibility. - Updated import paths in the CodeEditor stories and specs to reflect the new location of `codeSnippets`. - Introduced comprehensive test utilities for CodeMirror extension hooks, enhancing the testing framework's capabilities. * feat(CodeEditor): add comprehensive testing utilities for Panel component - Introduced `renderPanel` function to facilitate rendering of the Panel component with necessary context for testing. - Added `PanelSelectors` for consistent access to panel elements in tests. - Implemented various interaction methods for testing user interactions with the Panel, including format and copy button actions. - Enhanced README documentation to include new testing utilities and examples for better guidance on testing Panel interactions. * refactor(CodeEditor): update import paths for testing utilities - Changed import paths in various extension spec files to reflect the new location of testing utilities, improving organization and accessibility. - Ensured consistency across all extension tests by standardizing the import structure. * refactor(CodeEditor): update module references for undo/redo functionality - Changed references from `modules` to `coreModules` in the `handleUndo` and `handleRedo` functions to align with the updated module loading structure. - Improved code clarity and maintainability by ensuring consistent usage of the core modules for command handling. * refactor(CodeEditor): update testing utilities and documentation - Renamed mock functions to default stub functions for clarity in the CodeEditor context. - Updated the README to reflect changes in the testing utilities, including new context configuration options for overriding default functions in tests. - Enhanced test cases to utilize the new stub functions, improving consistency and maintainability in testing the Panel component. * refactor(CodeEditor): update import structure in useIndentExtension tests - Reorganized import statements in the useIndentExtension.spec.ts file to improve clarity and maintainability. - Moved the IndentUnits import to align with the updated structure of testing utilities. * refactor(CodeEditor): update Panel tests to use default context functions - Removed the use of mockPanelFunctions in Panel tests, replacing them with defaultPanelContextFunctions for improved clarity and consistency. - Updated test cases to directly utilize context configuration for undo and redo actions, enhancing maintainability and readability of the tests.
tsck
added a commit
that referenced
this pull request
Sep 15, 2025
* feat(CodeEditor): add undo and redo functionality to the editor - Implemented handleUndo and handleRedo methods to allow users to undo and redo editor actions. - Updated CodeEditorHandle interface to include undo and redo methods, enhancing the editor's capabilities. - Improved user experience by providing feedback when undo/redo actions are unavailable. * feat(CodeEditor): add undo and redo methods to context and editor - Introduced undo and redo functions in the CodeEditorContext to enhance user interaction. - Updated the CodeEditor component to integrate these new functionalities, improving the overall editing experience. * feat(Panel): integrate undo and redo functionality in the editor panel - Added handleUndoClick and handleRedoClick methods to the Panel component to utilize the new undo and redo functions from the CodeEditorContext. - Updated the onClick handlers for the Undo and Redo menu items to call the new methods, enhancing user interaction and experience. * feat(CodeEditor): implement undo and redo methods in tests and utilities - Added tests for undo and redo functionalities in the CodeEditor component, ensuring they work correctly with content changes. - Enhanced test utilities to include getContent, undo, and redo methods, providing a more comprehensive testing framework for the editor. - Updated the Panel component tests to verify the integration of undo and redo actions in the user interface, improving overall test coverage. * feat(CodeEditor): enhance imperative handle API and testing utilities - Updated the imperative handle test to expose a complete API, including methods for undo, redo, getContents, formatCode, and getEditorViewInstance. - Added a new utility function, getHandle, to retrieve the editor handle instance for testing imperative methods. - Modified the insertText function to default to inserting text at the end of the document, improving usability in tests. * feat(CodeEditor): enhance documentation and add imperative API details - Updated the README to clarify the various methods for formatting code in the CodeEditor, emphasizing the programmatic access through the CodeEditor ref. - Introduced a new section detailing the imperative API, including methods for content manipulation, formatting, and undo/redo operations. - Added examples for using the imperative methods, improving the documentation for developers. - Adjusted the formatting options description to enhance clarity and usability. * changeset * chore: remove obsolete clever-editors-undo changeset file * refactor(CodeEditor): reorganize testing utilities - Moved `codeSnippets` to a dedicated testing file for better organization and accessibility. - Updated import paths in the CodeEditor stories and specs to reflect the new location of `codeSnippets`. - Introduced comprehensive test utilities for CodeMirror extension hooks, enhancing the testing framework's capabilities. * feat(CodeEditor): add comprehensive testing utilities for Panel component - Introduced `renderPanel` function to facilitate rendering of the Panel component with necessary context for testing. - Added `PanelSelectors` for consistent access to panel elements in tests. - Implemented various interaction methods for testing user interactions with the Panel, including format and copy button actions. - Enhanced README documentation to include new testing utilities and examples for better guidance on testing Panel interactions. * refactor(CodeEditor): update import paths for testing utilities - Changed import paths in various extension spec files to reflect the new location of testing utilities, improving organization and accessibility. - Ensured consistency across all extension tests by standardizing the import structure. * refactor(CodeEditor): update module references for undo/redo functionality - Changed references from `modules` to `coreModules` in the `handleUndo` and `handleRedo` functions to align with the updated module loading structure. - Improved code clarity and maintainability by ensuring consistent usage of the core modules for command handling. * refactor(CodeEditor): update testing utilities and documentation - Renamed mock functions to default stub functions for clarity in the CodeEditor context. - Updated the README to reflect changes in the testing utilities, including new context configuration options for overriding default functions in tests. - Enhanced test cases to utilize the new stub functions, improving consistency and maintainability in testing the Panel component. * refactor(CodeEditor): update import structure in useIndentExtension tests - Reorganized import statements in the useIndentExtension.spec.ts file to improve clarity and maintainability. - Moved the IndentUnits import to align with the updated structure of testing utilities. * refactor(CodeEditor): update Panel tests to use default context functions - Removed the use of mockPanelFunctions in Panel tests, replacing them with defaultPanelContextFunctions for improved clarity and consistency. - Updated test cases to directly utilize context configuration for undo and redo actions, enhancing maintainability and readability of the tests.
tsck
added a commit
that referenced
this pull request
Sep 16, 2025
* feat(CodeEditor): add undo and redo functionality to the editor - Implemented handleUndo and handleRedo methods to allow users to undo and redo editor actions. - Updated CodeEditorHandle interface to include undo and redo methods, enhancing the editor's capabilities. - Improved user experience by providing feedback when undo/redo actions are unavailable. * feat(CodeEditor): add undo and redo methods to context and editor - Introduced undo and redo functions in the CodeEditorContext to enhance user interaction. - Updated the CodeEditor component to integrate these new functionalities, improving the overall editing experience. * feat(Panel): integrate undo and redo functionality in the editor panel - Added handleUndoClick and handleRedoClick methods to the Panel component to utilize the new undo and redo functions from the CodeEditorContext. - Updated the onClick handlers for the Undo and Redo menu items to call the new methods, enhancing user interaction and experience. * feat(CodeEditor): implement undo and redo methods in tests and utilities - Added tests for undo and redo functionalities in the CodeEditor component, ensuring they work correctly with content changes. - Enhanced test utilities to include getContent, undo, and redo methods, providing a more comprehensive testing framework for the editor. - Updated the Panel component tests to verify the integration of undo and redo actions in the user interface, improving overall test coverage. * feat(CodeEditor): enhance imperative handle API and testing utilities - Updated the imperative handle test to expose a complete API, including methods for undo, redo, getContents, formatCode, and getEditorViewInstance. - Added a new utility function, getHandle, to retrieve the editor handle instance for testing imperative methods. - Modified the insertText function to default to inserting text at the end of the document, improving usability in tests. * feat(CodeEditor): enhance documentation and add imperative API details - Updated the README to clarify the various methods for formatting code in the CodeEditor, emphasizing the programmatic access through the CodeEditor ref. - Introduced a new section detailing the imperative API, including methods for content manipulation, formatting, and undo/redo operations. - Added examples for using the imperative methods, improving the documentation for developers. - Adjusted the formatting options description to enhance clarity and usability. * changeset * chore: remove obsolete clever-editors-undo changeset file * refactor(CodeEditor): reorganize testing utilities - Moved `codeSnippets` to a dedicated testing file for better organization and accessibility. - Updated import paths in the CodeEditor stories and specs to reflect the new location of `codeSnippets`. - Introduced comprehensive test utilities for CodeMirror extension hooks, enhancing the testing framework's capabilities. * feat(CodeEditor): add comprehensive testing utilities for Panel component - Introduced `renderPanel` function to facilitate rendering of the Panel component with necessary context for testing. - Added `PanelSelectors` for consistent access to panel elements in tests. - Implemented various interaction methods for testing user interactions with the Panel, including format and copy button actions. - Enhanced README documentation to include new testing utilities and examples for better guidance on testing Panel interactions. * refactor(CodeEditor): update import paths for testing utilities - Changed import paths in various extension spec files to reflect the new location of testing utilities, improving organization and accessibility. - Ensured consistency across all extension tests by standardizing the import structure. * refactor(CodeEditor): update module references for undo/redo functionality - Changed references from `modules` to `coreModules` in the `handleUndo` and `handleRedo` functions to align with the updated module loading structure. - Improved code clarity and maintainability by ensuring consistent usage of the core modules for command handling. * refactor(CodeEditor): update testing utilities and documentation - Renamed mock functions to default stub functions for clarity in the CodeEditor context. - Updated the README to reflect changes in the testing utilities, including new context configuration options for overriding default functions in tests. - Enhanced test cases to utilize the new stub functions, improving consistency and maintainability in testing the Panel component. * refactor(CodeEditor): update import structure in useIndentExtension tests - Reorganized import statements in the useIndentExtension.spec.ts file to improve clarity and maintainability. - Moved the IndentUnits import to align with the updated structure of testing utilities. * refactor(CodeEditor): update Panel tests to use default context functions - Removed the use of mockPanelFunctions in Panel tests, replacing them with defaultPanelContextFunctions for improved clarity and consistency. - Updated test cases to directly utilize context configuration for undo and redo actions, enhancing maintainability and readability of the tests.
tsck
added a commit
that referenced
this pull request
Sep 16, 2025
* feat(CodeEditor): add undo and redo functionality to the editor - Implemented handleUndo and handleRedo methods to allow users to undo and redo editor actions. - Updated CodeEditorHandle interface to include undo and redo methods, enhancing the editor's capabilities. - Improved user experience by providing feedback when undo/redo actions are unavailable. * feat(CodeEditor): add undo and redo methods to context and editor - Introduced undo and redo functions in the CodeEditorContext to enhance user interaction. - Updated the CodeEditor component to integrate these new functionalities, improving the overall editing experience. * feat(Panel): integrate undo and redo functionality in the editor panel - Added handleUndoClick and handleRedoClick methods to the Panel component to utilize the new undo and redo functions from the CodeEditorContext. - Updated the onClick handlers for the Undo and Redo menu items to call the new methods, enhancing user interaction and experience. * feat(CodeEditor): implement undo and redo methods in tests and utilities - Added tests for undo and redo functionalities in the CodeEditor component, ensuring they work correctly with content changes. - Enhanced test utilities to include getContent, undo, and redo methods, providing a more comprehensive testing framework for the editor. - Updated the Panel component tests to verify the integration of undo and redo actions in the user interface, improving overall test coverage. * feat(CodeEditor): enhance imperative handle API and testing utilities - Updated the imperative handle test to expose a complete API, including methods for undo, redo, getContents, formatCode, and getEditorViewInstance. - Added a new utility function, getHandle, to retrieve the editor handle instance for testing imperative methods. - Modified the insertText function to default to inserting text at the end of the document, improving usability in tests. * feat(CodeEditor): enhance documentation and add imperative API details - Updated the README to clarify the various methods for formatting code in the CodeEditor, emphasizing the programmatic access through the CodeEditor ref. - Introduced a new section detailing the imperative API, including methods for content manipulation, formatting, and undo/redo operations. - Added examples for using the imperative methods, improving the documentation for developers. - Adjusted the formatting options description to enhance clarity and usability. * changeset * chore: remove obsolete clever-editors-undo changeset file * refactor(CodeEditor): reorganize testing utilities - Moved `codeSnippets` to a dedicated testing file for better organization and accessibility. - Updated import paths in the CodeEditor stories and specs to reflect the new location of `codeSnippets`. - Introduced comprehensive test utilities for CodeMirror extension hooks, enhancing the testing framework's capabilities. * feat(CodeEditor): add comprehensive testing utilities for Panel component - Introduced `renderPanel` function to facilitate rendering of the Panel component with necessary context for testing. - Added `PanelSelectors` for consistent access to panel elements in tests. - Implemented various interaction methods for testing user interactions with the Panel, including format and copy button actions. - Enhanced README documentation to include new testing utilities and examples for better guidance on testing Panel interactions. * refactor(CodeEditor): update import paths for testing utilities - Changed import paths in various extension spec files to reflect the new location of testing utilities, improving organization and accessibility. - Ensured consistency across all extension tests by standardizing the import structure. * refactor(CodeEditor): update module references for undo/redo functionality - Changed references from `modules` to `coreModules` in the `handleUndo` and `handleRedo` functions to align with the updated module loading structure. - Improved code clarity and maintainability by ensuring consistent usage of the core modules for command handling. * refactor(CodeEditor): update testing utilities and documentation - Renamed mock functions to default stub functions for clarity in the CodeEditor context. - Updated the README to reflect changes in the testing utilities, including new context configuration options for overriding default functions in tests. - Enhanced test cases to utilize the new stub functions, improving consistency and maintainability in testing the Panel component. * refactor(CodeEditor): update import structure in useIndentExtension tests - Reorganized import statements in the useIndentExtension.spec.ts file to improve clarity and maintainability. - Moved the IndentUnits import to align with the updated structure of testing utilities. * refactor(CodeEditor): update Panel tests to use default context functions - Removed the use of mockPanelFunctions in Panel tests, replacing them with defaultPanelContextFunctions for improved clarity and consistency. - Updated test cases to directly utilize context configuration for undo and redo actions, enhancing maintainability and readability of the tests.
tsck
added a commit
that referenced
this pull request
Sep 18, 2025
* feat(CodeEditor): add undo and redo functionality to the editor - Implemented handleUndo and handleRedo methods to allow users to undo and redo editor actions. - Updated CodeEditorHandle interface to include undo and redo methods, enhancing the editor's capabilities. - Improved user experience by providing feedback when undo/redo actions are unavailable. * feat(CodeEditor): add undo and redo methods to context and editor - Introduced undo and redo functions in the CodeEditorContext to enhance user interaction. - Updated the CodeEditor component to integrate these new functionalities, improving the overall editing experience. * feat(Panel): integrate undo and redo functionality in the editor panel - Added handleUndoClick and handleRedoClick methods to the Panel component to utilize the new undo and redo functions from the CodeEditorContext. - Updated the onClick handlers for the Undo and Redo menu items to call the new methods, enhancing user interaction and experience. * feat(CodeEditor): implement undo and redo methods in tests and utilities - Added tests for undo and redo functionalities in the CodeEditor component, ensuring they work correctly with content changes. - Enhanced test utilities to include getContent, undo, and redo methods, providing a more comprehensive testing framework for the editor. - Updated the Panel component tests to verify the integration of undo and redo actions in the user interface, improving overall test coverage. * feat(CodeEditor): enhance imperative handle API and testing utilities - Updated the imperative handle test to expose a complete API, including methods for undo, redo, getContents, formatCode, and getEditorViewInstance. - Added a new utility function, getHandle, to retrieve the editor handle instance for testing imperative methods. - Modified the insertText function to default to inserting text at the end of the document, improving usability in tests. * feat(CodeEditor): enhance documentation and add imperative API details - Updated the README to clarify the various methods for formatting code in the CodeEditor, emphasizing the programmatic access through the CodeEditor ref. - Introduced a new section detailing the imperative API, including methods for content manipulation, formatting, and undo/redo operations. - Added examples for using the imperative methods, improving the documentation for developers. - Adjusted the formatting options description to enhance clarity and usability. * changeset * chore: remove obsolete clever-editors-undo changeset file * refactor(CodeEditor): reorganize testing utilities - Moved `codeSnippets` to a dedicated testing file for better organization and accessibility. - Updated import paths in the CodeEditor stories and specs to reflect the new location of `codeSnippets`. - Introduced comprehensive test utilities for CodeMirror extension hooks, enhancing the testing framework's capabilities. * feat(CodeEditor): add comprehensive testing utilities for Panel component - Introduced `renderPanel` function to facilitate rendering of the Panel component with necessary context for testing. - Added `PanelSelectors` for consistent access to panel elements in tests. - Implemented various interaction methods for testing user interactions with the Panel, including format and copy button actions. - Enhanced README documentation to include new testing utilities and examples for better guidance on testing Panel interactions. * refactor(CodeEditor): update import paths for testing utilities - Changed import paths in various extension spec files to reflect the new location of testing utilities, improving organization and accessibility. - Ensured consistency across all extension tests by standardizing the import structure. * refactor(CodeEditor): update module references for undo/redo functionality - Changed references from `modules` to `coreModules` in the `handleUndo` and `handleRedo` functions to align with the updated module loading structure. - Improved code clarity and maintainability by ensuring consistent usage of the core modules for command handling. * refactor(CodeEditor): update testing utilities and documentation - Renamed mock functions to default stub functions for clarity in the CodeEditor context. - Updated the README to reflect changes in the testing utilities, including new context configuration options for overriding default functions in tests. - Enhanced test cases to utilize the new stub functions, improving consistency and maintainability in testing the Panel component. * refactor(CodeEditor): update import structure in useIndentExtension tests - Reorganized import statements in the useIndentExtension.spec.ts file to improve clarity and maintainability. - Moved the IndentUnits import to align with the updated structure of testing utilities. * refactor(CodeEditor): update Panel tests to use default context functions - Removed the use of mockPanelFunctions in Panel tests, replacing them with defaultPanelContextFunctions for improved clarity and consistency. - Updated test cases to directly utilize context configuration for undo and redo actions, enhancing maintainability and readability of the tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #3063
LG-5129/ce-undo-redo was accidentally overwritten on the
integration/code-editorintegration branch. This branch is a remerge of that branch. It should contain everything that was originally merged in #3063 .The following is what went wrong: