Skip to content

CDRIVER-6134 check overflow #2159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 24, 2025
Merged

CDRIVER-6134 check overflow #2159

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f901a46
CDRIVER-6134 check overflow
kevinAlbs Oct 22, 2025
66ee5fb
use `mlib_add`
kevinAlbs Oct 24, 2025
ac539c2
init to 0
kevinAlbs Oct 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/libmongoc/src/mongoc/mongoc-cyrus.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ _mongoc_cyrus_canon_user(sasl_conn_t *conn,

// `inlen` is a string length (excluding trailing NULL).
// Cyrus-SASL passes an `out` buffer of size `out_max + 1`. Assume `out_max` is the max to be safe.
if (inlen + 1 >= out_max) {
if (inlen == UINT_MAX || inlen + 1 >= out_max) {
Copy link
Contributor

@vector-of-bool vector-of-bool Oct 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, I recommend using mlib_add() here, since it is not sensitive to the types of its argument, while this relies on UINT_MAX always being the correct value to check.

Copy link
Collaborator Author

@kevinAlbs kevinAlbs Oct 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. Updated to use mlib_add().

MONGOC_ERROR("SASL username too large");
return SASL_BUFOVER;
}
Expand Down