CSHARP-3547: CSOT: read-write concern #1752
Conversation
| var subject = new CreateCollectionOperation(_collectionNamespace, _messageEncoderSettings) | ||
| { | ||
| WriteConcern = writeConcern | ||
| }; | ||
| var operationContext = hasOperationTimeout ? new OperationContext(TimeSpan.FromSeconds(42), CancellationToken.None) : OperationContext.NoTimeout; |
There was a problem hiding this comment.
I noticed you used this 42 magic number for setting the operation timeout when we need. Should we extract this into a constant that can be used across all the tests?
There was a problem hiding this comment.
Do not think so 🤣, 42 - does not have any special meaning =) Other then it is "answer to the ultimate question of life, the universe, and everything". It could be any number, simply not-zero timeout.
There was a problem hiding this comment.
I was suggesting extracting this to a constant so that if we need to change this value in the future, we'll only need to update it in one place rather than hunting down and replacing all instances of the magic number 42 throughout the codebase. But I don't insist, up to you.
No description provided.