-
Notifications
You must be signed in to change notification settings - Fork 916
GODRIVER-3102: Perf comparison #2134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
API Change ReportNo changes found! |
62e5e7c
to
8cc29fd
Compare
…nto GODRIVER-3102-3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
P.S. If getting the comment to post in Github is going to take significantly more time, I recommend merging this PR without that functionality and adding it in a subsequent PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! 👍
GODRIVER-3102
Summary
After perf task is run, a perf comparison between the mainline benchmarks and the patch benchmarks is now made. This comparison calculates for h-score, z-score, and % change from the latest mainline stable region, and outputs the specific benchmarks that have a 95% confidence level of change (ie. where |z-score| < 1.96). Ultimately will be posted as a PR comment (but currently just outputs in Evergreen).
To run locally,
Background & Motivation
Have a better idea of how commits will affect performance before being merged into the mainline branch, more proactive than current method.