Skip to content

GODRIVER-3102: Perf comparison #2134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 39 commits into from
Jul 29, 2025
Merged

Conversation

zhouselena
Copy link
Contributor

@zhouselena zhouselena commented Jul 21, 2025

GODRIVER-3102

Summary

After perf task is run, a perf comparison between the mainline benchmarks and the patch benchmarks is now made. This comparison calculates for h-score, z-score, and % change from the latest mainline stable region, and outputs the specific benchmarks that have a 95% confidence level of change (ie. where |z-score| < 1.96). Ultimately will be posted as a PR comment (but currently just outputs in Evergreen).

To run locally,

perf_uri_private_endpoint="<endpoint>" VERSION_ID="<version>" sh etc/perf-pr-comment.sh

Background & Motivation

Have a better idea of how commits will affect performance before being merged into the mainline branch, more proactive than current method.

@mongodb-drivers-pr-bot mongodb-drivers-pr-bot bot added dependencies Pull requests that update a dependency file priority-3-low Low Priority PR for Review labels Jul 21, 2025
Copy link
Contributor

API Change Report

No changes found!

@zhouselena zhouselena marked this pull request as ready for review July 22, 2025 17:48
@zhouselena zhouselena requested a review from a team as a code owner July 22, 2025 17:48
matthewdale
matthewdale previously approved these changes Jul 25, 2025
Copy link
Collaborator

@matthewdale matthewdale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

P.S. If getting the comment to post in Github is going to take significantly more time, I recommend merging this PR without that functionality and adding it in a subsequent PR.

qingyang-hu
qingyang-hu previously approved these changes Jul 25, 2025
prestonvasquez
prestonvasquez previously approved these changes Jul 28, 2025
Copy link
Collaborator

@matthewdale matthewdale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

@zhouselena zhouselena merged commit 0c9c840 into mongodb:master Jul 29, 2025
29 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file priority-3-low Low Priority PR for Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants