Skip to content

PYTHON-4931 Add spec tests for GridFS rename #2431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 15, 2025

Conversation

sleepyStick
Copy link
Contributor

  • removed associated patch files and lines in remove-unimplemented-tests.sh
  • Based on the spec test changes, I'm guessing that CorruptGridFile is now a client error as opposed to just a generic error
  • maybe random note: When i ran the gridfs tests locally, I saw that we're skipping test test_download_when_an_intermediate_chunk_is_the_wrong_size pending PYTHON-4598 but I cant see that ticket on jira? (it says its either been deleted or I don't have permissions?)

@sleepyStick sleepyStick requested a review from a team as a code owner July 15, 2025 16:16
@sleepyStick sleepyStick requested a review from blink1073 July 15, 2025 17:08
@blink1073
Copy link
Member

Hmm, it looks like PYTHON-4598 was deleted, can you please open a new ticket linking to PYTHON-4242 where those tests were skipped noting that the referenced ticket was deleted and we should look into unskipping these tests.

@blink1073
Copy link
Member

Yeah the spec PR is titled "Add spec tests for GridFS rename and require client errors", so I think your assumption is correct.

Copy link
Member

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sleepyStick
Copy link
Contributor Author

sleepyStick commented Jul 15, 2025

Ticket Opened! Thanks for the clarification!
https://jira.mongodb.org/browse/PYTHON-5441

@sleepyStick sleepyStick merged commit 83fcf7c into mongodb:master Jul 15, 2025
76 of 77 checks passed
@sleepyStick sleepyStick deleted the PYTHON-4931 branch July 15, 2025 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants