-
Notifications
You must be signed in to change notification settings - Fork 1.8k
feat(NODE-6472): findOne and find no longer keep open cursors #4580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+356
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11b1cf5
to
9fe1c2d
Compare
durran
commented
Jul 22, 2025
baileympearson
requested changes
Jul 23, 2025
feaeb6b
to
5ba6dfe
Compare
Co-authored-by: Bailey Pearson <[email protected]>
Co-authored-by: Bailey Pearson <[email protected]>
baileympearson
approved these changes
Aug 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes
findOne
to set options that will not require a cursor or a killCursors command. Updatesfind
to not leave cursors open on the server when batch size and limit are equal.What is changing?
batchSize
tobatchSize + 1
when the limit is equal to it.Is there new documentation needed for these changes?
API docs on the findOne options.
What is the motivation for this change?
NODE-6472
Release Highlight
collection.findOne()
andcollection.find()
will no longer potentially leave open cursors on the serverThe
findOne
command will now always set thelimit
option to1
andsingleBatch
totrue
. Thelimit
,noCursorResponse
andbatchSize
options have also been deprecated, and the command will guarantee no more cursors can be orphaned and nokillCursors
command will be potentially executed.find
will now setlimit
tobatchSize + 1
when both options were equal, to avoid leaving cursors open.Double check the following
npm run check:lint
scripttype(NODE-xxxx)[!]: description
feat(NODE-1234)!: rewriting everything in coffeescript