-
Notifications
You must be signed in to change notification settings - Fork 1.8k
test(NODE-7179): migrate tests to import directly from src folder
#4736
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8158091 to
da062d6
Compare
tadjik1
commented
Oct 17, 2025
tadjik1
commented
Oct 17, 2025
src foldersrc folder
src foldersrc folder
durran
approved these changes
Oct 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Summary of Changes
Change imports inside
test/folder to import entities directly fromsrc/folder (avoidingmongodb.tswrapper).Notes for Reviewers
Initially I thought about splitting different pieces in different commits, but ending up having 40+ commits which probably not helping at all. Therefore I would suggest to review file be file and mark files as "viewed" in GH interface. However, this is a matter of preference. Let me know if you would like me to squash certain commits to simplify the review process. In general this is only about imports, there are few places where I touched test code as well, I left comments in those places (hopefully didn't miss any).
What is the motivation for this change?
This work is part of a larger, ongoing initiative to convert all tests to use async/await, with the ultimate goal of removing the legacy driver wrapper.
Double check the following
npm run check:lint)type(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript