Skip to content

Conversation

@tadjik1
Copy link
Member

@tadjik1 tadjik1 commented Oct 16, 2025

Description

Summary of Changes

Change imports inside test/ folder to import entities directly from src/ folder (avoiding mongodb.ts wrapper).

Notes for Reviewers

Initially I thought about splitting different pieces in different commits, but ending up having 40+ commits which probably not helping at all. Therefore I would suggest to review file be file and mark files as "viewed" in GH interface. However, this is a matter of preference. Let me know if you would like me to squash certain commits to simplify the review process. In general this is only about imports, there are few places where I touched test code as well, I left comments in those places (hopefully didn't miss any).

What is the motivation for this change?

This work is part of a larger, ongoing initiative to convert all tests to use async/await, with the ultimate goal of removing the legacy driver wrapper.

Double check the following

  • Lint is passing (npm run check:lint)
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@tadjik1 tadjik1 force-pushed the NODE-7179 branch 3 times, most recently from 8158091 to da062d6 Compare October 17, 2025 08:28
@tadjik1 tadjik1 changed the title test(NODE-7179): migrate tests to import directly from src folder [WIP] test(NODE-7179): migrate tests to import directly from src folder Oct 17, 2025
@tadjik1 tadjik1 changed the title [WIP] test(NODE-7179): migrate tests to import directly from src folder test(NODE-7179): migrate tests to import directly from src folder Oct 24, 2025
@tadjik1 tadjik1 marked this pull request as ready for review October 24, 2025 20:21
@tadjik1 tadjik1 requested a review from a team as a code owner October 24, 2025 20:21
@durran durran self-assigned this Oct 27, 2025
@durran durran added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Oct 27, 2025
@durran durran merged commit 39f2ec8 into main Oct 27, 2025
27 checks passed
@durran durran deleted the NODE-7179 branch October 27, 2025 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Primary Review In Review with primary reviewer, not yet ready for team's eyes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants