Skip to content

Conversation

@maastha
Copy link
Collaborator

@maastha maastha commented Aug 31, 2025

Description

Updates guides & examples for removal of mongodbatlas_advanced_cluster deprecated params

Link to any related issue(s): CLOUDP-333683

Type of change:

  • Bug fix (non-breaking change which fixes an issue). Please, add the "bug" label to the PR.
  • New feature (non-breaking change which adds functionality). Please, add the "enhancement" label to the PR. A migration guide must be created or updated if the new feature will go in a major version.
  • Breaking change (fix or feature that would cause existing functionality to not work as expected). Please, add the "breaking change" label to the PR. A migration guide must be created or updated.
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the contributing guides
  • I have checked that this change does not generate any credentials and that they are NOT accidentally logged anywhere.
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code
  • If changes include deprecations or removals I have added appropriate changelog entries.
  • If changes include removal or addition of 3rd party GitHub actions, I updated our internal document. Reach out to the APIx Integration slack channel to get access to the internal document.

Further comments

Base automatically changed from CLOUDP-333683-remove-old-schema-attrs to CLOUDP-320243-dev-2.0.0 September 3, 2025 23:44
Copilot AI review requested due to automatic review settings September 3, 2025 23:50
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview - OUTDATED - Please IGNORE

This PR removes deprecated parameters from the mongodbatlas_advanced_cluster resource and related configurations to complete the cleanup initiated in version 2.0.0. The changes focus on eliminating references to deprecated sharding configurations and updating documentation and examples to reflect the current supported schema.

Key changes include:

  • Removal of deprecated parameter references in deprecation messages
  • Cleanup of deprecated num_shards and use_replication_spec_per_shard attributes from test files and examples
  • Documentation updates to reflect the removal of deprecated attributes
  • Import statement cleanup where deprecated constants are no longer needed

Reviewed Changes

Copilot reviewed 25 out of 25 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
internal/service/team/resource_team.go Updates deprecation message placeholder for team usernames parameter
internal/service/team/data_source_team.go Updates deprecation message placeholder for team usernames data source
internal/service/projectinvitation/resource_project_invitation.go Removes deprecation message and unused import for project invitation resource
internal/service/projectinvitation/data_source_project_invitation.go Removes deprecation message and unused import for project invitation data source
internal/service/project/resource_project_schema.go Removes deprecation message for teams parameter
internal/service/project/model_project.go Removes deprecation message and unused imports for project model
internal/service/orginvitation/resource_org_invitation.go Removes deprecation message and unused import for org invitation resource
internal/service/orginvitation/data_source_org_invitation.go Removes deprecation message and unused import for org invitation data source
internal/service/atlasuser/data_source_atlas_users.go Removes deprecation messages and unused import for atlas users data source
internal/service/atlasuser/data_source_atlas_user.go Removes deprecation messages and unused import for atlas user data source
internal/service/advancedcluster/testdata/*.yaml Removes deprecated use_replication_spec_per_shard parameters from test configurations
examples/*/main.tf Removes deprecated num_shards parameters from advanced cluster examples
examples/mongodbatlas_encryption_at_rest/aws/multi-region-cluster/modules/multi-region-cluster/main.tf Converts from deprecated num_shards to new sharding configuration with separate replication specs
docs/resources/advanced_cluster.md Updates documentation to remove references to deprecated parameters and configurations
docs/guides/*.md Updates migration guides and documentation to reflect removal of deprecated attributes
docs/data-sources/advanced_cluster*.md Updates data source documentation to remove deprecated parameter references
.github/workflows/code-health.yml Modifies CI workflow dependencies and test configuration

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@maastha maastha force-pushed the CLOUDP-333683-docs-examples branch from 1903756 to 8247c92 Compare September 3, 2025 23:59
@maastha maastha merged commit c41eb56 into CLOUDP-320243-dev-2.0.0 Sep 4, 2025
43 checks passed
@maastha maastha deleted the CLOUDP-333683-docs-examples branch September 4, 2025 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants