-
Notifications
You must be signed in to change notification settings - Fork 210
doc: Updates guides & examples for removal of mongodbatlas_advanced_cluster deprecated params
#3634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: Marco Suma <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview - OUTDATED - Please IGNORE
This PR removes deprecated parameters from the mongodbatlas_advanced_cluster resource and related configurations to complete the cleanup initiated in version 2.0.0. The changes focus on eliminating references to deprecated sharding configurations and updating documentation and examples to reflect the current supported schema.
Key changes include:
- Removal of deprecated parameter references in deprecation messages
- Cleanup of deprecated
num_shardsanduse_replication_spec_per_shardattributes from test files and examples - Documentation updates to reflect the removal of deprecated attributes
- Import statement cleanup where deprecated constants are no longer needed
Reviewed Changes
Copilot reviewed 25 out of 25 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| internal/service/team/resource_team.go | Updates deprecation message placeholder for team usernames parameter |
| internal/service/team/data_source_team.go | Updates deprecation message placeholder for team usernames data source |
| internal/service/projectinvitation/resource_project_invitation.go | Removes deprecation message and unused import for project invitation resource |
| internal/service/projectinvitation/data_source_project_invitation.go | Removes deprecation message and unused import for project invitation data source |
| internal/service/project/resource_project_schema.go | Removes deprecation message for teams parameter |
| internal/service/project/model_project.go | Removes deprecation message and unused imports for project model |
| internal/service/orginvitation/resource_org_invitation.go | Removes deprecation message and unused import for org invitation resource |
| internal/service/orginvitation/data_source_org_invitation.go | Removes deprecation message and unused import for org invitation data source |
| internal/service/atlasuser/data_source_atlas_users.go | Removes deprecation messages and unused import for atlas users data source |
| internal/service/atlasuser/data_source_atlas_user.go | Removes deprecation messages and unused import for atlas user data source |
| internal/service/advancedcluster/testdata/*.yaml | Removes deprecated use_replication_spec_per_shard parameters from test configurations |
| examples/*/main.tf | Removes deprecated num_shards parameters from advanced cluster examples |
| examples/mongodbatlas_encryption_at_rest/aws/multi-region-cluster/modules/multi-region-cluster/main.tf | Converts from deprecated num_shards to new sharding configuration with separate replication specs |
| docs/resources/advanced_cluster.md | Updates documentation to remove references to deprecated parameters and configurations |
| docs/guides/*.md | Updates migration guides and documentation to reflect removal of deprecated attributes |
| docs/data-sources/advanced_cluster*.md | Updates data source documentation to remove deprecated parameter references |
| .github/workflows/code-health.yml | Modifies CI workflow dependencies and test configuration |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
...ongodbatlas_encryption_at_rest/aws/multi-region-cluster/modules/multi-region-cluster/main.tf
Show resolved
Hide resolved
1903756 to
8247c92
Compare
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Leo Antoli <[email protected]>
Description
Updates guides & examples for removal of
mongodbatlas_advanced_clusterdeprecated paramsLink to any related issue(s): CLOUDP-333683
Type of change:
Required Checklist:
Further comments