Skip to content

Test disposing GRContext does not crash for Metal backend #3258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 22, 2025
Merged

Test disposing GRContext does not crash for Metal backend #3258

merged 2 commits into from
Aug 22, 2025

Conversation

jeremy-visionaid
Copy link
Contributor

@jeremy-visionaid jeremy-visionaid commented Apr 30, 2025 •
edited by mattleibow
Loading

Description of Change

Unit test for double free fixed in

Bugs Fixed

Fixes: #3178

API Changes

None.

Behavioral Changes

None.

Required skia PR

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of main at time of PR
  • Merged related skia PRs
  • Changes adhere to coding standard
  • Updated documentation

@jeremy-visionaid jeremy-visionaid changed the title Fix crash in GRContext metal finalizer Fix crash in GRContext Metal backend finalizer Apr 30, 2025
@jeremy-visionaid jeremy-visionaid force-pushed the grcontext-metal-finalizer branch 4 times, most recently from a53ebbd to 8a1443c Compare April 30, 2025 22:05
@jeremy-visionaid jeremy-visionaid marked this pull request as ready for review May 23, 2025 02:58
@jeremy-visionaid jeremy-visionaid changed the title Fix crash in GRContext Metal backend finalizer Fix crash disposing GRContext for Metal backend May 23, 2025
@jeremy-visionaid jeremy-visionaid force-pushed the grcontext-metal-finalizer branch from 8a1443c to 0fb74fb Compare June 3, 2025 21:10
@jeremy-visionaid jeremy-visionaid mentioned this pull request Jun 25, 2025
Merged
5 tasks
mattleibow
mattleibow requested changes Aug 19, 2025
View reviewed changes
Copy link
Contributor

@mattleibow mattleibow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not 100% sure if we are supposed to retain, but according to instruments this does not leak. So I guess we are supposed to?

I see various places that have retain on there, so this is looking safe for now.

@github-project-automation github-project-automation bot moved this to Changes Requested in SkiaSharp Backlog Aug 19, 2025
@jeremy-visionaid jeremy-visionaid mentioned this pull request Aug 20, 2025
Closed
1 task
@jeremy-visionaid jeremy-visionaid force-pushed the grcontext-metal-finalizer branch from 0fb74fb to c9de72c Compare August 21, 2025 22:43
@jeremy-visionaid
Copy link
Contributor Author

I've moved the corresponding fix for the double free to mono/skia#159

@jeremy-visionaid jeremy-visionaid changed the title Fix crash disposing GRContext for Metal backend Test disposing GRContext does not crash for Metal backend Aug 21, 2025
@jeremy-visionaid jeremy-visionaid mentioned this pull request Aug 22, 2025
Merged
3 tasks
@mattleibow mattleibow force-pushed the grcontext-metal-finalizer branch from 50cefd3 to cc80eb4 Compare August 22, 2025 17:51
@mattleibow
Copy link
Contributor

Thanks for all this investigation!

@mattleibow mattleibow merged commit c1cd0ce into mono:main Aug 22, 2025
1 check passed
@github-project-automation github-project-automation bot moved this from Changes Requested to Done in SkiaSharp Backlog Aug 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattleibow mattleibow mattleibow approved these changes

Assignees
No one assigned
Labels
community ✨
Projects
SkiaSharp Backlog
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] iOS: Crash when GC collects SKMetalView resources
2 participants
@jeremy-visionaid @mattleibow