Skip to content

Conversation

jeremy-visionaid
Copy link
Contributor

SKTimeDateTimeInternal assumes the DateTime is local, but it might be UTC.

Description of Change

Ensure that the time zone calculation correctly accounts for local vs UTC time

Behavioral Changes

None.

Required skia PR

None.

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of main at time of PR
  • Merged related skia PRs
  • Changes adhere to coding standard
  • Updated documentation

SKTimeDateTimeInternal assumes the DateTime is local, but it might be
UTC.
@mattleibow
Copy link
Contributor

/azp run

Copy link

No pipelines are associated with this pull request.

@mattleibow mattleibow merged commit 60e8175 into mono:main Aug 18, 2025
3 checks passed
Copy link

Triage Summary

Labels will be applied to indicate issues related to reliability, the SkiaSharp area, and the PDF backend, specifically addressing problems with DateTime handling.

This issue is not classified as a regression, as it focuses on an incorrect assumption rather than a failure of previously functional behavior.

Detailed Summary and Actions

Summary of the triage:

  • The issue affects DateTime handling in the application, which can lead to unexpected behaviors.
  • The issue involves the SKDocumentPdfMetadata, suggesting it is related to the SkiaSharp library.
  • The PDF backend is relevant due to its connection to PDF processing and the specific area of concern within the issue.

Summary of the actions that will be performed:

Action Item Description
Apply Label tenet/reliability The issue relates to the incorrect assumption about DateTime handling which could lead to unexpected behaviors.
Apply Label area/SkiaSharp The issue relates to the handling of DateTime in the SKDocumentPdfMetadata, which is part of the SkiaSharp library.
Apply Label backend/PDF The issue pertains to SKDocumentPdfMetadata, which relates to PDF processing, making the PDF backend label appropriate.

Additional remarks:

  • The issue description does not specify any operating system context and primarily focuses on DateTime conversion logic, which is why platform-specific labels were not applied.

This entire triage process was automated by AI and mistakes may have been made. Please let us know so we can continue to improve.

@github-actions github-actions bot added area/SkiaSharp Issues that relate to the C# binding of SkiaSharp. backend/PDF tenet/reliability Issues relating to crashes or unexpected behaviors labels Aug 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/SkiaSharp Issues that relate to the C# binding of SkiaSharp. backend/PDF community ✨ tenet/reliability Issues relating to crashes or unexpected behaviors
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants