Skip to content

[4.0.0]: Refactor: Index seasons and shows by their number #185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
glensc wants to merge 6 commits into
base: master
Choose a base branch
from
Draft

[4.0.0]: Refactor: Index seasons and shows by their number #185

glensc wants to merge 6 commits into from

Conversation

@glensc
Copy link
Contributor

@glensc glensc commented Jan 15, 2022

Extracted from #176 as the changes are breaking changes.

This will make only one trakt.tv API request to create list of TVSeason with TVEpisode objects.

The properties are indexed in a dict by .number rather being a list:

    show = TVShow('Game of Thrones')

    seasons = show.seasons
    assert len(seasons) == 9
    assert seasons[1].episodes[1].title == 'Winter Is Coming'

@glensc glensc mentioned this pull request Jan 15, 2022
Open
@glensc glensc changed the title [4.0.0]: Refactor: Index seasons and shows by ther number [4.0.0]: Refactor: Index seasons and shows by their number Oct 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@glensc