security(json): Add nesting depth limit to prevent stack overflow #2745
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 1298Details
💛 - Coveralls |
peter-jerry-ye
force-pushed
the
quake/json-parse-stack-overflow
branch
from
be6740d to
9b542f8
Compare
FlyCloudC
reviewed
Sep 19, 2025
quake
force-pushed
the
quake/json-parse-stack-overflow
branch
2 times, most recently
from
f6b985d to
d70ddbd
Compare
| /// Parse a JSON input string into a Json value, with an optional maximum nesting depth (default is 1024) | ||
| pub fn parse( | ||
| input : String, | ||
| max_nesting_depth? : Int = 1024, |
There was a problem hiding this comment.
Is there any reason for this number, i.e. what's the number picked by the others?
There was a problem hiding this comment.
follow python / java(Jackson), the default limit is around 1000.
bobzhang
force-pushed
the
quake/json-parse-stack-overflow
branch
from
d70ddbd to
7aaf50c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a nesting depth limit to the JSON parser to fix a security vulnerability.
Without a depth limit, parsing a deeply nested JSON string can lead to a stack overflow, which crashes the program. This can be used as a DoS attack.
This is a common security measure found in many other languages and libraries (like Go, Rust, and Python) to ensure safe JSON parsing. This change makes moonbit json parser more robust and secure.