refactor: make arrayview immutable #2754
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 1285Details
💛 - Coveralls |
bobzhang
reviewed
Sep 22, 2025
| /// TODO: use specific type for non-js backend | ||
| /// Notice: may need to move to builtin | ||
| priv struct ArraySlice[T] { | ||
| array : Array[T] |
There was a problem hiding this comment.
cc @Yu-zh this is a valid use case where we would like it to be value type
bobzhang
force-pushed
the
zihang/make-arrayview-immutable
branch
from
f28eddb to
489bfa1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.