-
Notifications
You must be signed in to change notification settings - Fork 354
The ability to generate trait methods using types #1054
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
PuffyWithEyes
wants to merge
8
commits into
mozilla:master
Choose a base branch
from
PuffyWithEyes:traits-types
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
46764bb
Fixed handling of trait methods containing the unsafe attribute
6f8fa31
Added tests for unsafe methotd's atributs
602172d
Added test for unsafe(no_mangle) attribute
d3252cf
Added the ability to generate trait methods using types
740f41c
Fixed the generation of associated constants
99be358
Now associative types generate typedefs
847794a
Changed tests and test results
7bccce6
Clippy fix
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -627,6 +627,38 @@ impl Type { | |
} | ||
} | ||
|
||
pub fn try_set_assoc_name<T>(&mut self, assoc_name: T) -> Result<(), String> | ||
where | ||
T: Into<String>, | ||
{ | ||
let mut current = self; | ||
loop { | ||
match current { | ||
Type::Ptr { ref mut ty, .. } => current = ty, | ||
Type::Path(ref mut generic) => { | ||
generic.set_assoc_ty(assoc_name); | ||
|
||
break Ok(()); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Just |
||
} | ||
_ => { | ||
break Err(format!( | ||
"Failed to set path ({}) for type {:?}", | ||
assoc_name.into(), | ||
current | ||
)) | ||
} | ||
} | ||
} | ||
} | ||
|
||
pub fn name_is_self(&self) -> bool { | ||
if let Some(name) = self.get_root_path() { | ||
name.name() == "Self" | ||
} else { | ||
false | ||
} | ||
} | ||
|
||
pub fn specialize(&self, mappings: &[(&Path, &GenericArgument)]) -> Type { | ||
match *self { | ||
Type::Ptr { | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this actually right? What happens if I return different levels of pointer-ness?