Fix parsing submodule dir for 2018 convention #1070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

BiagioFesta wants to merge 1 commit into mozilla:master from BiagioFesta:wip/bfesta/submod-dir

+1 −1

BiagioFesta commented Apr 23, 2025

Fix for: #1069


          Fix parsing submodule dir for 2018 convention

1f8c79a

Collaborator

emilio commented May 20, 2025

Ok, so I think in the example in #1069, the depth == 0 is confusing us. I think we need a test, but also, I'm not convinced hardcoding lib.rs is the right fix? IIRC you can totally customize the main path, right? https://doc.rust-lang.org/cargo/reference/cargo-targets.html#configuring-a-target

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet